Add TensorContainer trait to allow more argument types for TensorVisitors in #469 #472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreylowman
approved these changes
Feb 22, 2023
| path: self.path, | ||
| }; | ||
| Field::iter_tensors(&mut walker)?; | ||
| std::mem::drop(walker); |
There was a problem hiding this comment.
Yes, if you remove it, rust will consider self.path to be mutably borrowed on the next line.
| impl<W: Write + Seek, E: Dtype + NumpyDtype, D: CopySlice<E>> VisitTensors<E, D> | ||
| for zip::ZipWriter<W> | ||
| { | ||
| type Container = &'static (); |
There was a problem hiding this comment.
Yeah lets go with your suggestion in the PR description about using the unconstructable enums instead of these, purely for readability. I know i'd forget in a couple months what this means haha.
type Container = TensorRef;makes so much sense!
| } | ||
| } | ||
|
|
||
| impl<T: TensorContainer> TensorContainer for Option<T> { |
There was a problem hiding this comment.
I could see this being used for optional fields (e.g. bias if we go the Option route), nice!
coreylowman
added a commit
that referenced
this pull request
Feb 22, 2023
* Temp commit * Using visitors for npz * Moving missing grads test to optimizers * Format * Rename ModuleWalker to TensorVisitor * Fix missing update of ModuleWalker * Fixing old docs * Moves name out of TensorOptions * Rename TensorOptions helper methods * move visitors into nn * Fixing example * Add TensorContainer trait to allow more argument types for TensorVisitors in #469 (#472) * Add TensorContainer trait; deduplicate code in visitors/base.rs * Implement TensorContainer for tuples, Option, and Vec * run cargo fmt * Add TensorMut and TensorRef tensor contains * Renamign visitors -> tensor_collection * Reorg tensor collection * Renaming * Moving name to first arg * Fixing clippy warnings * Update src/nn/tensor_collection/visitor.rs Co-authored-by: nkoppel <nathankoppel0@gmail.com> * Adding #non_exhausting to TensorOptions --------- Co-authored-by: nkoppel <nathankoppel0@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds TensorContainer to allow implementers of VisitTensors to specify their own argument types. This is done with the
Containerassociated type, which represents some collection of immutable and mutable references to the same type. References to a particular type are represented with&'static ()and&'static mut (), but these could be substituted for other types including unconstructable enums, like these:Related to #469 and #460.