+
Skip to content

Rename to add_dim. #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Rename to add_dim. #471

merged 2 commits into from
Feb 21, 2023

Conversation

infalmo
Copy link
Contributor

@infalmo infalmo commented Feb 21, 2023

No description provided.

@coreylowman
Copy link
Owner

@infalmo looks good. What are your thoughts on changing it to trait PushDim and fn push_dim? Otherwise will merge

@coreylowman coreylowman merged commit fc38a83 into coreylowman:main Feb 21, 2023
@infalmo infalmo deleted the rename-upd branch February 21, 2023 22:43
@infalmo
Copy link
Contributor Author

infalmo commented Feb 21, 2023

AddDim is good. PushDim sounds like we're pushing the dimension, which doesn't make sense tbh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载