Add boolean operations and choose. #415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
where soon)
where soon)|
Looking great on first read through - probably going to need a couple more days with this one 😀 |
coreylowman
requested changes
Feb 1, 2023
|
|
||
| use std::sync::Arc; | ||
|
|
||
| const MODULE_NAME: &str = "/boolean.ptx"; |
There was a problem hiding this comment.
nitpick for consistency
Suggested change
| const MODULE_NAME: &str = "/boolean.ptx"; | |
| const MODULE_NAME: &str = "boolean"; |
|
Thanks for the contribution! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
and,or,xor, andnotfor Tensors. In the process, however, I expanded the definition of OnesTensor and OneFillTensor to all implementors of Unit, which caused Cpu and Cuda to implement Device for all implementors of Unit. Because of this, we now have to specify tensors' dtypes more often.I also had to use take_async instead of alloc_zeros_async to create the result tensors because cudarc doesn't currently implement ValidAsZeroBits for booleans. This is already fixed in cudarc's latest main, so this can be changed the next time cudarc releases. I figured that take_async was preferred to transmuting a CudaSlice<u8> to a CudaSlice<bool>.
Now also implements
choose, resolving #305.