Fix GELU CUDA kernel compilation #409
Conversation
| @@ -1,4 +1,6 @@ | |||
| #include "unary_op_macros.cuh" | |||
| #define _USE_MATH_DEFINES | |||
There was a problem hiding this comment.
What does this do exactly? Also have you tried compiling all this on a non GNU and MSVC device (I can verify on my dev machine later)
There was a problem hiding this comment.
From the MSVC documentation
The math constants aren't defined in Standard C/C++. To use them, you must first define
_USE_MATH_DEFINES, and then include<cmath>or<math.h>.
The #define is used here to essentially set a flag so that the math constants are defined in the math.h header file.
If we take a look at the (relevant documentation) we can see how it works:
A
#definewithout a token-string removes occurrences of identifier from the source file. The identifier remains defined and can be tested by using the#if definedand#ifdefdirectives.
(Emphasis mine)
I have not tested with other toolchains than stable-x86_64-pc-windows-gnu and stable-x86_64-pc-windows-msvc.
|
Apparently there exist also floating point versions of these constants which are available if EDIT: This does not seem to work on MSVC |
Closes #407
Math Constant macros were not included which caused issues when trying to compile.
While at it, I also changed
tanhtotanhfand added aconstexprwhere appropriate.