-
-
Notifications
You must be signed in to change notification settings - Fork 104
Removes ModuleBuilder
, Adds BuildModule
& BuildOnDevice
#405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkoppel
reviewed
Jan 26, 2023
coreylowman
commented
Jan 26, 2023
coreylowman
commented
Jan 26, 2023
coreylowman
commented
Jan 26, 2023
coreylowman
commented
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #388
See discussions in issue and in #394.
This removes
ModuleBuilder
, notably you can't calldev.build_module()
anymore. Instead users should use eitherBuildModule
if they are using only the Cpu device, or if they want to specify device in the typing. Or the more generalBuildOnDevice
, which should be called likeModel::build_on_device(&dev)
.A con of this is that this does complicate creating modules a bit since there are two distinct ways to create them. The main suggested pathway should be:
type Model = ...
)BuildOnDevice
to build it (e.g.let mut model = Model::build_on_device(&dev)
)This makes it trivial to switch devices in the future.
Error message for BuildOnDevice with the wrong device
Error message for BuildModule with the wrong device