+
Skip to content

Chat send is slow #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Chat send is slow #503

merged 2 commits into from
Dec 11, 2024

Conversation

ticruz38
Copy link
Collaborator

There was an unnecessary roundtrip to the signer when sending a message. We were trying to unwrap a message we had just wrapped. This was fixed by publishing the rumor to the local repository before publishing the wrapped version to the relays.

The editor content is now cleared as soon as the message is sent. A loader replaces the send icon while the message is being wrapped and signed. Once the message is ready to be published, it appears in the channel, where it can still be canceled during the delay set by the user in the app settings.

Screen.Recording.2024-12-10.at.16.42.38.mov

- add cancelable button to message
- show message status
@ticruz38 ticruz38 changed the base branch from master to dev December 10, 2024 15:51
@staab
Copy link
Collaborator

staab commented Dec 10, 2024

Looking better:

  • Go ahead and use the same loading icon used elsewhere (fa-circle-notch)
  • See if you can use publishThunk and get the message to show up immediately
  • On cancel, does the note content get put back into the editor?

@ticruz38
Copy link
Collaborator Author

ticruz38 commented Dec 10, 2024

See if you can use publishThunk and get the message to show up immediately

It is using publishthunk, but it is the wrapped message that is sent and saved to the repository, publishthunk do work well, it's just that I'm unwrapping an incoming message for which I know the rumor already.

On cancel, does the note content get put back into the editor?

Yes

Screen.Recording.2024-12-10.at.18.02.09.mov

@staab staab merged commit 9f46c4f into coracle-social:dev Dec 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载