Creation and Submission delay and status #457
Conversation
|
This diff is wonky too. For some reason it's showing all my commits as your commits. I don't know what you're doing to make that happen, but can you reset/rebase to clean it up? |
There was a problem hiding this comment.
You'll need to rebase this on dev since I merged the groups stuff. Also, take a look at @welshman/app's thunk module, it solves a lot of these problems much more cleanly. I'm not sure if we can integrate it cleanly yet, but see if you run into any problems with that.
So I tried, for the NoteCreate, it's ok, I can watch the thunk status and take action depending on it (clear the modal, show the toaster etc). The canceled is handled with thunk.controller.abort(). Which is cleaner than keeping a cancel state in the component. For the reply, it's feasible too but the thunk will have to travel across 3 or 4 components like this. Atm I am using the publish command that populates the $publishes store, I can then import directly in NotePending and check out the state of my pub. It seems cleaner. |
Look for the
I'm actually hoping to migrate from publishes to thunks (which are a superset of the functionality), this issue is actually a step in that migration. We can just add these to |
|
ok I'll make the migration to thunk, almost there |
|
Just finished the thunk migration and rebased from dev Might be worth another look |
.husky/pre-commit
Outdated
| @@ -1 +1 @@ | |||
| npm run check | |||
| npm run format && npm run check | |||
There was a problem hiding this comment.
| npm run format && npm run check | |
| npm run check |
| {#key "key"} | ||
| {#key $toast.id} |
There was a problem hiding this comment.
This was actually correct, it's to avoid an animation when there is already a toast visible. Unless something changed?
There was a problem hiding this comment.
I have a weird behaviour with the "key" key where the content of 2 different toast is merged together.
I have the first delay toast staying for 3 seconds followed by the "publish" toast with a 5 seconds timeout. If I don't have a uniq key, then both toast content are merged together until the 5 seconds timeout of the second toast has elapsed.
- slider to define send_delay
This PR address issues #369 and #235
When replying, there is a (configurable) 5 seconds countdown before the note is sent
Once the note is sent, it tracks the pending requests via a loading bar
Once all request are settled, it shows a status summary, with the possibility to open a more detailed modal
The post status is displayed for 30 seconds, after which the actions buttons shows up like a normal note
