388 - Update the displayList implementation and move into the project #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Looks great. |
staab
pushed a commit
that referenced
this pull request
Oct 15, 2024
…#439) * move displayList into the project and utilize Intl.ListFormat * target es2021 to make ts happy when utilizing ListFormt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #388. Pulled
displayListinto the project and made use ofIntl.ListFormtinstead of pure string concatenation. Maybe this is a slight improvement to the hurdak implementation? Added unit tests, so hopefully the original functionality is maintained. Alsotsconfigwas not happy, sayingIntl.ListFormatdid not exist, so I pointed the tsconfig target toes2021so we could have access to it. Not sure about the broader implications of this change.