+
Skip to content

Conversation

Gakhramanzode
Copy link
Contributor

add the project https://github.com/prymitive/karma for monitoring category

@Gakhramanzode
Copy link
Contributor Author

@apetruhin what do you think about this PR?

@def
Copy link
Member

def commented Oct 3, 2025

The problem with this PR is that both the title and commit message are not meaningful.

@Gakhramanzode Gakhramanzode changed the title Update application_category.go add missing monitoring category Oct 3, 2025
@Gakhramanzode
Copy link
Contributor Author

The problem with this PR is that both the title and commit message are not meaningful.

fix it

@def
Copy link
Member

def commented Oct 3, 2025

I don’t think it’s a good idea to match karma this way. Someone might install it with a different Helm release name, for example. I’d suggest adjusting your instance config with this pattern, since we can’t be sure it’ll work for everyone

@Gakhramanzode
Copy link
Contributor Author

I understand your vision and what you mean. I removed this app

@def def merged commit 4f8baf1 into coroot:main Oct 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载