+
Skip to content

Rename isabstract method #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

Rename isabstract method #803

wants to merge 7 commits into from

Conversation

PrasannaPal21
Copy link

Fixes #482

Renamed misleading isAbstract method to hasSubclasses to accurately reflect what it does - checks if a class has child classes. The old method name conflicted with Pharo's standard meaning and caused confusion.

Changes Made

  • Created new hasSubclasses method with improved implementation
  • Made old isAbstract method deprecated but still working
  • Updated all references in CMAbstractModel class
  • Added proper tests for the new functionality

Benefits

This change makes the code more intuitive while maintaining compatibility with existing code. Developers can now better understand class hierarchy operations in Cormas without confusion about what "abstract" means in this context.

Testing Code

The changes were tested using these Playground snippets:

"Test 1: Testing the hasSubclasses method directly"
CMEntity hasSubclasses.  "Should return true"
CMInstanceParameter hasSubclasses.  "Should return false"
CMEntity isAbstract.  "Should return true but show deprecation warning"
"Get the model instance"
model := CMMockModel new.

"Test allTheEntities: method with a class that has subclasses"
model allTheEntities: CMEntity.

"Test entitiesOfClass: with a class that has subclasses (should return empty collection)"
model entitiesOfClass: CMEntity.

"Test with a concrete class that doesn't have subclasses"
"Replace ConcreteEntityClass with an actual concrete entity class from your model"
model entitiesOfClass: CMInstanceParameter. 
CMEntityTest new testCormasEntityHasSubclasses.
CMEntityTest new testCormasEntityIsAbstract.

olekscode and others added 7 commits March 24, 2025 14:24
@olekscode
Added missing images
3dc32c7
@olekscode
Update README.md
e320998
@notavii
03d1a47 
Pharo13.0.0:
#Branch: master Fixes #
#Please use one of those
#feat:
#fix:
#refactor:
#chore:
#comment: renamed  "ESE(regular) - special location" to "accessing cells" and the protocol "ESE initialize- release" contains 3 methods: createCells, initializeRegularNumberOfRows: numberOfColumns: neighbourhood: closed: and numberOfNeighbours - all of them moved to "initialization" protocol.
@olekscode
Merge pull request cormas#795 from notavii/master
88120c2 
[Fix] Remove ESE protocols
@jodz4k
Removed CMAVerage150to500ValueCollector class
20f9725
@olekscode
Merge pull request cormas#797 from jodz4k/master
c01e76f 
Removed CMAVerage150to500ValueCollector class
@PrasannaPal21
Rename isAbstract method to hasSubclasses for clarity
369b446
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PrasannaPal21 @olekscode @notavii @jodz4k
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载