+
Skip to content

fix: don't crash when file is removed from a templated .gitignore #1886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2024
Merged

fix: don't crash when file is removed from a templated .gitignore #1886

merged 1 commit into from
Dec 21, 2024

Conversation

fresh2dev
Copy link
Contributor

resolves #1773

@fresh2dev fresh2dev mentioned this pull request Dec 12, 2024
Closed
sisp
sisp requested changes Dec 16, 2024
View reviewed changes
Copy link
Member

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this fix, @fresh2dev! 🙏 Looks great! I have only a few minor remarks.

@fresh2dev fresh2dev force-pushed the fix/gitignored-unignored-1773 branch from 6f0b953 to a55bcf2 Compare December 17, 2024 02:04
@fresh2dev
Copy link
Contributor Author

Thanks for contributing this fix, @fresh2dev! 🙏 Looks great! I have only a few minor remarks.

Thanks for the review! I pushed the requested changes. 🤙

sisp
sisp reviewed Dec 21, 2024
View reviewed changes
Copy link
Member

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow review cycles. 😞 I have one more question regarding the test case.

@fresh2dev fresh2dev force-pushed the fix/gitignored-unignored-1773 branch from a55bcf2 to 89e2404 Compare December 21, 2024 20:06
@codecov Codecov
Copy link

codecov bot commented Dec 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.77%. Comparing base (2dc1687) to head (89e2404).
Report is 95 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1886      +/-   ##
==========================================
+ Coverage   97.76%   97.77%   +0.01%     
==========================================
  Files          49       49              
  Lines        5232     5261      +29     
==========================================
+ Hits         5115     5144      +29     
  Misses        117      117
Flag Coverage Δ
unittests 97.77% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sisp
sisp approved these changes Dec 21, 2024
View reviewed changes
Copy link
Member

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉 Thank you very much for this contribution, @fresh2dev! 🙏

@fresh2dev
Copy link
Contributor Author

Thanks for the review, and for helping support this game-changing solution 🙏

🚀

@sisp sisp merged commit 9ccabd4 into copier-org:master Dec 21, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sisp sisp sisp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ProcessExecutionError when a file is un-ignored across template versions

2 participants

@fresh2dev @sisp
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载