Change report URL before running specification #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…correct URLs in test report
nigelcharman
requested changes
Mar 17, 2018
|
|
||
| @RunWith(ConcordionRunner.class) | ||
| @FailFast | ||
| @ExpectedToFail |
There was a problem hiding this comment.
With @ExpectedToFail present, the specification does not exhibit the failure that is fixed in RunCommand.
You will need to remove @ExpectedToFail and then also move this fixture and related specification from the src/test to the src/test-dummies folder. This will make sure that this failing specification is excluded from the results.
I have also noticed that SpecCallingFailFastFixture is not linked to the specification suite (under Concordion.html). I'm happy to address this in a separate PR.
|
Applied changes as requested |
|
Fixes #255 . Thanks @bkoperski ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change report URL before running specification in order to guarantee correct URLs in test report.
This Pull Request is related to issue #255.