-
-
Notifications
You must be signed in to change notification settings - Fork 95
Significant redesign of app bar / app chooser / top bar / context menu paradigm #1197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h new back button structure limited to full window dialogs
…ling to work correctly
rcoreilly
approved these changes
Sep 2, 2024
This was referenced Sep 2, 2024
Closed
kkoreilly
added a commit
to compcogneuro/web
that referenced
this pull request
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the initial release, one of the biggest complaints and questions was about the ability to remove the top app bar. People accurately saw the top app bar as excessively opinionated and an inefficient use of screen real estate. Therefore, I have completed a major refactoring of our approach to this area.
Overall, this represents a significant improvement that will decrease bloat, increase developer control, and ease future changes. The v0.4 release notes will contain a more accessible summary of the changes made in this PR.
Here are the main changes:
AppBar
/AppBars
/TopAppBar
has been removed entirely.Bars
/TopBar
etc still exist.Toolbar
inside of theTopBar
, that is still completely possible and encouraged, but exclusively in your control, with no automatic support (see the bottom of the toolbars page for an example).TopAppBar
overflow menu have been relocated to the defaultScene.ContextMenus
.Scene.ContextMenus
are now automatically inherited by all widgets within the scene.Scene.ContextMenus
are also included when fetching keyboard shortcuts.AppChooser
(the search chooser in theTopAppBar
) has been relocated to a button in the default scene context menu and renamed toMenuSearch
.MenuSearcher
interface on a widget.TopAppBar
has been made contextual such that it will only show up when needed (inFullWindow
but notNewWindow
dialogs and windows).Stage.CloseOnBack
property has been removed.Stage.BackButton
property for changing whether the back button is added.pages
toolbar for returning to the previous page that also only shows up when needed.Body.AddTitle
andBody.AddText
functions have been removed.NewBody
is now automatically used to make a title widget in dialogs. You can change this behavior by settingStage.DisplayTitle
.Body.AddText
, you can make a standard text widget withNewText
and set itsText.Type
to the newTextSupporting
.Here are some other changes that indirectly resulted from the main changes:
BarsInherit
became entirely useless and was removed.OverflowMenu
s they want to anyToolbar
s they make in theTopBar
, so the awkwardtree.Plan.Parent
has been removed.BarFuncs
(such as forTopBar
etc) now take abar *Frame
instead of aparent Widget
, which is effectively the same but makes things much clearer and less ambiguous.GetTopAppBar
andGetBar
functions have been removed.FilePicker
has been improved to have its own directoryChooser
at the top, since it no longer integrates with a centralized app chooser.This fixes #1074 and supersedes and thus closes #1072.