fix: defaults for null values #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behaviour differs from circe-generic-extras case classes should be constructed with default values when cursor points to JNull circe#115
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
=======================================
Coverage 26.45% 26.45%
=======================================
Files 9 9
Lines 601 601
Branches 36 36
=======================================
Hits 159 159
Misses 442 442
Continue to review full report at Codecov.
|
|
Thanks, looks good to me! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
behaviour differs from circe-generic-extras
case classes should be constructed with default values when cursor
points to JNull
#115