-
Notifications
You must be signed in to change notification settings - Fork 28
Use sbt circe plugin #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Use sbt circe plugin #423
Conversation
On hold until we get the org plugin out the door. After that I'll update this PR to use that instead (it's also how I'm testing the plugin locally) |
Hi @lorandszakacs, do you have any more commits for this that you need to push up? Just want to make sure this gets over the line if someone needs to pick it up. Thanks! |
Any way I can help with this? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #423 +/- ##
===========================================
+ Coverage 31.33% 81.09% +49.76%
===========================================
Files 8 6 -2
Lines 584 164 -420
Branches 63 27 -36
===========================================
- Hits 183 133 -50
+ Misses 401 31 -370
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
prePR
command, which is the only thing that modified source code outside of the buildAlso, the current build definitely uses the equivalent of
ThisBuild / tlSonatypeUseLegacyHost := false
(LE: I meant the exact opposite. Booleans are hard). Not sure if the circe org can publish to new hosts though.I abstained from upgrading various versions in this PR 😅 I'll follow-up with that if thisi gets merged.