+
Skip to content

Conversation

lorandszakacs
Copy link

@lorandszakacs lorandszakacs commented Sep 20, 2022

  • title says it all, use the new sbt-circe-io plugin 😄. Depends on initial implementation of plugin sbt-circe-org#1
  • removed configs keys that sbt was warning me about
  • not entirely sure if Mima needs more config 🤷
  • enables warnings, but disables fatal CI warning. We should fix all at some point
  • use the sama scalafmt.conf as circe
  • inherit scalafix w/ organizeImports from the sbt plugin
  • ran the prePR command, which is the only thing that modified source code outside of the build

Also, the current build definitely uses the equivalent of ThisBuild / tlSonatypeUseLegacyHost := false (LE: I meant the exact opposite. Booleans are hard). Not sure if the circe org can publish to new hosts though.

I abstained from upgrading various versions in this PR 😅 I'll follow-up with that if thisi gets merged.

@lorandszakacs lorandszakacs marked this pull request as draft September 21, 2022 11:47
@lorandszakacs
Copy link
Author

On hold until we get the org plugin out the door. After that I'll update this PR to use that instead (it's also how I'm testing the plugin locally)
circe/sbt-circe-org#1

@lorandszakacs lorandszakacs changed the title Use sbt typelevel Use sbt circe plugin Sep 24, 2022
@zmccoy
Copy link
Member

zmccoy commented Feb 6, 2023

Hi @lorandszakacs, do you have any more commits for this that you need to push up? Just want to make sure this gets over the line if someone needs to pick it up. Thanks!

@nafg
Copy link

nafg commented Apr 24, 2023

Any way I can help with this?

@zmccoy zmccoy marked this pull request as ready for review April 26, 2023 21:48
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.09%. Comparing base (799c1b9) to head (32d7be1).
Report is 78 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #423       +/-   ##
===========================================
+ Coverage   31.33%   81.09%   +49.76%     
===========================================
  Files           8        6        -2     
  Lines         584      164      -420     
  Branches       63       27       -36     
===========================================
- Hits          183      133       -50     
+ Misses        401       31      -370     
Flag Coverage Δ
2.12 80.98% <100.00%> (?)
2.13 76.25% <85.71%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载