+
Skip to content

test: Tune down DELTACHAT_SAVE_TMP_DB hint #6998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2025
Merged

test: Tune down DELTACHAT_SAVE_TMP_DB hint #6998

merged 1 commit into from
Jul 12, 2025

Conversation

Hocuri
Copy link
Collaborator

@Hocuri Hocuri commented Jul 12, 2025

Follow-up for #6992

Since we're printing the hint to stderr now, rather than stdout (as per link2xt's suggestion), it was too noisy. Also, it was printed once for every test account rather than once per test.

Now, it integrates nicely with rust's hint to enable a backtrace:

  stderr ───

    thread 'chat::chat_tests::test_broadcasts_name_and_avatar' panicked at src/chat/chat_tests.rs:2757:5:
    assertion failed: `(left == right)`

    Diff < left / right > :
    <true
    >false


    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
    note: If you want to examine the database files, set environment variable DELTACHAT_SAVE_TMP_DB=1

        FAIL [   0.265s] deltachat chat::chat_tests::test_broadcast

@Hocuri Hocuri requested review from link2xt and iequidoo July 12, 2025 08:42
@Hocuri
test: Tune down DELTACHAT_SAVE_TMP_DB hint
f8c154e 
Follow-up for #6992

Since we're printing the hint to stderr now, rather than stdout (as per
link2xt's suggestion), it was too noisy. Also, it was printed once for
every test account rather than once per test.

Now, it integrates nicely with rust's hint to enable a backtrace.
@Hocuri Hocuri force-pushed the hoc/nicer-save-test-db branch from 170dd97 to f8c154e Compare July 12, 2025 08:46
@Hocuri
Copy link
Collaborator Author

Hocuri commented Jul 12, 2025

CI failure is unrelated, I only touched rust-test code, and CI failure is in python-test code

@Hocuri Hocuri merged commit f5e8c80 into main Jul 12, 2025
27 of 29 checks passed
@Hocuri Hocuri deleted the hoc/nicer-save-test-db branch July 12, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iequidoo iequidoo iequidoo approved these changes

@link2xt link2xt Awaiting requested review from link2xt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hocuri @iequidoo
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载