+
Skip to content

fix: Update slug for zoom app #11795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2023
Merged

fix: Update slug for zoom app #11795

merged 1 commit into from
Oct 12, 2023

Conversation

alishaz-polymath
Copy link
Member

What does this PR do?

Updates the slug as it is supposed to be
From zoomvideo -> zoom

Requirement/Documentation

image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Oct 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2023 3:05pm
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2023 3:05pm
cal-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2023 3:05pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2023 3:05pm
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2023 3:05pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Oct 10, 2023 3:05pm

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023 •
edited
Loading

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link to collect XP and win prizes!

@zomars zomars added ai area: AI, cal.ai core area: core, team members only labels Oct 10, 2023
@Udit-takkar Udit-takkar changed the title hotfix: Update slug for zoom app fix: Update slug for zoom app Oct 10, 2023
@alishaz-polymath
Copy link
Member Author

Let's wait for @joeauyeung review before merging as he has most context on this 🙏

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023 •
edited
Loading

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 155.8 KB (🟢 -21.26 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Fifty-seven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/404 83.93 KB 239.73 KB 68.49% (🟡 +0.15%)
/500 85.16 KB 240.96 KB 68.84% (🟡 +0.15%)
/[user]/[type] 235.93 KB 391.73 KB 111.92% (🟡 +0.27%)
/[user]/[type]/embed 235.96 KB 391.76 KB 111.93% (🟡 +0.27%)
/[user]/embed 88.73 KB 244.53 KB 69.86% (🟡 +0.14%)
/apps/[slug] 280.61 KB 436.41 KB 124.69% (🟡 +0.14%)
/apps/[slug]/[...pages] 549.92 KB 705.72 KB 201.63% (🟡 +0.26%)
/apps/[slug]/setup 81.32 KB 237.12 KB 67.75% (🟡 +0.15%)
/apps/categories 241.41 KB 397.2 KB 113.49% (🟡 +0.14%)
/apps/categories/[category] 245.44 KB 401.24 KB 114.64% (🟡 +0.14%)
/auth/error 94.35 KB 250.15 KB 71.47% (🟡 +0.15%)
/auth/forgot-password 96.75 KB 252.54 KB 72.16% (🟡 +0.14%)
/auth/forgot-password/[id] 100.41 KB 256.21 KB 73.20% (🟡 +0.14%)
/auth/login 113.4 KB 269.2 KB 76.91% (🟡 +0.15%)
/auth/logout 82.06 KB 237.86 KB 67.96% (🟡 +0.15%)
/auth/oauth2/authorize 111.67 KB 267.47 KB 76.42% (🟡 +0.15%)
/auth/saml-idp 79.59 KB 235.39 KB 67.25% (🟡 +0.15%)
/auth/signin 79.67 KB 235.46 KB 67.28% (🟡 +0.14%)
/auth/sso/[provider] 79.7 KB 235.5 KB 67.29% (🟡 +0.14%)
/auth/sso/direct 79.63 KB 235.43 KB 67.27% (🟡 +0.14%)
/auth/verify 98.54 KB 254.34 KB 72.67% (🟡 +0.14%)
/auth/verify-email 85.07 KB 240.87 KB 68.82% (🟡 +0.15%)
/availability/troubleshoot 242.08 KB 397.88 KB 113.68% (🟡 +0.14%)
/d/[link]/[slug] 235.93 KB 391.73 KB 111.92% (🟡 +0.27%)
/maintenance 79.8 KB 235.6 KB 67.31% (🟡 +0.15%)
/more 241.03 KB 396.83 KB 113.38% (🟡 +0.14%)
/org/[orgSlug] 220.18 KB 375.98 KB 107.42% (🟡 +0.15%)
/org/[orgSlug]/[user] 226.56 KB 382.36 KB 109.24% (🟡 +0.15%)
/org/[orgSlug]/[user]/[type] 236.1 KB 391.9 KB 111.97% (🟡 +0.27%)
/org/[orgSlug]/[user]/[type]/embed 236.12 KB 391.92 KB 111.98% (🟡 +0.27%)
/org/[orgSlug]/team/[slug] 220.19 KB 375.99 KB 107.43% (🟡 +0.14%)
/org/[orgSlug]/team/[slug]/[type] 235.96 KB 391.75 KB 111.93% (🟡 +0.27%)
/payment/[uid] 110.77 KB 266.57 KB 76.16% (🟡 +0.15%)
/settings/admin/users 249.5 KB 405.29 KB 115.80% (🟡 +0.14%)
/settings/admin/users/[id]/edit 338.06 KB 493.85 KB 141.10% (🟡 +0.14%)
/settings/admin/users/add 337.79 KB 493.59 KB 141.02% (🟡 +0.15%)
/settings/developer/api-keys 251.89 KB 407.69 KB 116.48% (🟡 +0.14%)
/settings/developer/webhooks/new 252.6 KB 408.39 KB 116.68% (🟡 +0.14%)
/settings/organizations/appearance 254.31 KB 410.11 KB 117.17% (🟢 -1.43%)
/settings/organizations/teams/other/[id]/appearance 256.93 KB 412.73 KB 117.92% (🟡 +0.20%)
/settings/teams/[id]/appearance 256.92 KB 412.72 KB 117.92% (🟡 +0.20%)
/settings/teams/[id]/members 369.55 KB 525.34 KB 150.10% (🟡 +0.14%)
/settings/teams/[id]/onboard-members 149.7 KB 305.5 KB 87.29% (🟡 +0.14%)
/settings/teams/[id]/profile 439.8 KB 595.59 KB 170.17% (🟡 +0.14%)
/settings/teams/[id]/sso 257 KB 412.8 KB 117.94% (🟡 +0.14%)
/settings/teams/new 186.01 KB 341.81 KB 97.66% (🟡 +0.14%)
/signup 124.99 KB 280.79 KB 80.23% (🟡 +0.14%)
/team/[slug] 220.14 KB 375.94 KB 107.41% (🟡 +0.14%)
/team/[slug]/[type] 235.92 KB 391.72 KB 111.92% (🟡 +0.27%)
/team/[slug]/[type]/embed 235.95 KB 391.75 KB 111.93% (🟡 +0.27%)
/team/[slug]/embed 220.19 KB 375.98 KB 107.42% (🟡 +0.15%)
/teams 241.28 KB 397.08 KB 113.45% (🟡 +0.14%)
/video/[uid] 237.99 KB 393.79 KB 112.51% (🟡 +0.15%)
/video/meeting-ended/[uid] 89 KB 244.79 KB 69.94% (🟡 +0.15%)
/video/meeting-not-started/[uid] 88.64 KB 244.43 KB 69.84% (🟡 +0.15%)
/video/no-meeting-found 80.9 KB 236.7 KB 67.63% (🟡 +0.14%)
/workflows/[workflow] 389.16 KB 544.95 KB 155.70% (🟡 +0.14%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@deploysentinel
Copy link

deploysentinel bot commented Oct 10, 2023 •
edited
Loading

Current Playwright Test Results Summary

✅ 147 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 10/12/2023 10:11:36am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 33bfede

Started: 10/12/2023 10:08:26am UTC

⚠️ Flakes

📄   apps/web/playwright/login.2fa.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
2FA Tests should allow a user to enable 2FA and login using 2FA
Retry 1 • Initial Attempt
1.70% (5) 5 / 294 runs
failed over last 7 days
36.05% (106) 106 / 294 runs
flaked over last 7 days
📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

 2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt
2.27% (7) 7 / 308 runs
failed over last 7 days
20.78% (64) 64 / 308 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt
5.19% (16) 16 / 308 runs
failed over last 7 days
94.16% (290) 290 / 308 runs
flaked over last 7 days

View Detailed Build Results

PeerRich
PeerRich previously requested changes Oct 11, 2023
View reviewed changes
Copy link
Member

@PeerRich PeerRich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will cause sideeffects.

@PeerRich PeerRich closed this Oct 11, 2023
@Udit-takkar
Copy link
Contributor

@PeerRich i think we should wait for @joeauyeung's reply before we close this.

refreshOAuthTokens requires appSlug in the second parameter which should have been "zoom" not "zoomvideo" which is the name of directory but not the appSlug

@joeauyeung
Copy link
Contributor

@Udit-takkar is right. This should be the app slug. I think we can improve on this PR by instead of hard coding "zoom" we can use the app.slug directly.

@PeerRich there won't be any side effects in our app. The app slug is being passed into refreshOAuthToken which only uses the slug when a self-hoster wants to sync app credentials.

@joeauyeung joeauyeung reopened this Oct 12, 2023
@PeerRich PeerRich dismissed their stale review October 12, 2023 12:49

i was wrong

@PeerRich PeerRich merged commit 522fd64 into main Oct 12, 2023
@PeerRich PeerRich deleted the hotfix/incorrect-zoom-slug branch October 12, 2023 12:49
@PeerRich
Copy link
Member

I think we can improve on this PR by instead of hard coding "zoom" we can use the app.slug directly.

lets do a follow up PR

@PeerRich PeerRich mentioned this pull request Oct 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeerRich PeerRich PeerRich approved these changes

@joeauyeung joeauyeung Awaiting requested review from joeauyeung

@zomars zomars Awaiting requested review from zomars

@hariombalhara hariombalhara Awaiting requested review from hariombalhara

@Udit-takkar Udit-takkar Awaiting requested review from Udit-takkar

Assignees
No one assigned
Labels
ai area: AI, cal.ai core area: core, team members only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alishaz-polymath @Udit-takkar @joeauyeung @PeerRich @zomars
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载