From 9710cd880c47baee7dd65a4244640f48bbbd087b Mon Sep 17 00:00:00 2001 From: Sasha Fomin Date: Fri, 5 Sep 2025 18:02:46 +0200 Subject: [PATCH 1/2] Simple checklist --- pull_request_template.md | 58 +++++++++++++--------------------------- 1 file changed, 18 insertions(+), 40 deletions(-) diff --git a/pull_request_template.md b/pull_request_template.md index 34b23a3..fe6f7a9 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -1,51 +1,29 @@ -## ๐Ÿšฆ Release Freeze Checklist +**[Jira Ticket](https://blinkist.atlassian.net/browse/CK-XXX)** -This PR is being created during a **release freeze**. Please answer the following questions clearly before requesting review: +**Change Type:** -### ๐Ÿ” Risk Awareness -- **What does this PR change, and why is it critical enough to go out during a freeze?** - _Provide clear justification._ +**Domain:** -- **What is the risk level of this change (low / medium / high)? Why?** - _Be explicit about possible failure modes._ +## Description ---- + -### ๐Ÿ“Š Monitoring & Metrics -- **How will you monitor this release in production?** - _List dashboards, alerts, or logs youโ€™ll watch._ +### Gatekeepers (must all be โœ… before merge) -- **What metrics or monitors will help detect if something goes wrong?** - _E.g., error rates, latency, conversion drops._ +- [ ] I have performed a self-review of my own code +- [ ] There is an SLO or monitor that can capture a failure -- **Do you have an alert configured that would notify the right people if an issue arises?** - _Yes/No, details if yes._ +### AI-Generated Code +- [ ] This PR includes AI-generated code + - [ ] **I have performed a self-review of the generated code** ---- +### How has this been tested? -### ๐Ÿงช Testing & Rollout -- **How has this change been tested (unit, integration, staging, manual)?** - _Add links to test results if possible._ +- [ ] Tested on staging +- [ ] Tested locally -- **Is there a way to safely roll this out (feature flag, canary, % rollout)?** - _Describe rollout plan._ +### Observability -- **What is the rollback plan if something goes wrong?** - _Be specific about steps and impact._ - ---- - -### ๐Ÿ‘ฅ Ownership & Communication -- **Who is responsible for monitoring this change after release?** - _List names/teams and handover details._ - -- **Have the relevant stakeholders been informed (QA, Engineering, Product)?** - _Yes/No, mention names if yes._ - ---- - -โœ… **Please confirm:** -- [ ] I have reviewed the risks and monitoring plan with my team. -- [ ] I am confident this change is safe to release during the freeze. - ---- +- Dashboards updated/created: +- SLOs updated/created: +- Key metrics to watch post-deploy: From a9f63063d5c5033431416bebea5486804ebbe7fd Mon Sep 17 00:00:00 2001 From: Sasha Fomin Date: Fri, 5 Sep 2025 18:06:15 +0200 Subject: [PATCH 2/2] Update pull request template for clarity and standards --- pull_request_template.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pull_request_template.md b/pull_request_template.md index fe6f7a9..cb80e4e 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -11,11 +11,12 @@ ### Gatekeepers (must all be โœ… before merge) - [ ] I have performed a self-review of my own code -- [ ] There is an SLO or monitor that can capture a failure +- [ ] SLO or monitor exists that would detect a failure ### AI-Generated Code - [ ] This PR includes AI-generated code - - [ ] **I have performed a self-review of the generated code** + - [ ] **I verified correctness of the implementation** + - [ ] **I verified that code meets Blinkist standards** ### How has this been tested?