+
Skip to content

Conversation

mario-holubar
Copy link
Contributor

Building on #64, I added functionality to expand grids in the other direction.

Should probably rename either these or the expand_* functions as they don't match now.
I like prepend / append as they convey directionality, but they also kind of imply insertion of data rather than just resizing.
Alternatively something like expand_rows_before could work.
Thoughts?

Copy link
Owner

@becheran becheran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me. Just Remote the commented Code sections please.

@mario-holubar mario-holubar requested a review from becheran July 25, 2025 11:06
Copy link
Owner

@becheran becheran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@becheran becheran merged commit 80e96ff into becheran:master Jul 29, 2025
5 checks passed
@mario-holubar mario-holubar deleted the prepending branch July 29, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载