test/parallel: add a test for negative jobs number arguments #693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
martin-schulze-vireso
requested changes
Jan 25, 2023
martin-schulze-vireso
approved these changes
Jan 25, 2023
Before commit 48b0d26, -j2 and -j -2 both triggered an infinite loop. That commit fixed the infinite loop but -j2 and -j -2 are still parsed the same. In the corresponding code review bats-core#657 Martin expressed an intent to change the parser and parse these differently in the future. In commit 0ec3619 Martin added a "no infinite loop" test for "-j2". However this test will stop testing negative arguments when the parser changes (the test will also have to be adjusted when the parser changes). Add one additional test with a "-j -3" argument that will test a negative argument forever. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
cc22e67 to
2da73a0
Compare
|
Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before commit 48b0d26, -j2 and -j -2 both triggered an infinite loop. That commit fixed the infinite loop but -j2 and -j -2 are still parsed the same. In the corresponding code review #657 Martin expressed an intent to change the parser and parse these differently in the future.
In commit 0ec3619 Martin added a "no infinite loop" test for "-j2". However this test will stop testing negative arguments when the parser changes (the test will also have to be adjusted when the parser changes).
Add one additional test with a "-j -3" argument that will test a negative argument forever.
Signed-off-by: Marc Herbert marc.herbert@intel.com