+
Skip to content

Conversation

robert-smartbear
Copy link
Contributor

Goal

ViewControllers were kept in memory for up to 10 seconds after being dismissed.

Design

Removed a strong reference holding ViewControllers for additional time. Added handling for when ViewControllers are deallocated before the 10 seconds timeout

Testing

E2E tests

@robert-smartbear robert-smartbear changed the title Fixed issue where ViewControllers were kept in memory for up to 10 seconds after being dismissed. Fixed issue where ViewControllers were kept in memory for up to 10 seconds after being dismissed May 6, 2025
DariaKunoichi
DariaKunoichi previously approved these changes May 6, 2025
@robert-smartbear robert-smartbear force-pushed the robert/plat-14166_view_controller_dealloc_delay_fix branch from d44b3f2 to 69be9e6 Compare May 6, 2025 09:15
Copy link

github-actions bot commented May 6, 2025

BugsnagPerformance.framework binary size increased by 2,136 bytes from 597,584 to 599,720

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.7% +1.05Ki  +0.7% +1.05Ki    String Table
  +0.8% +1.02Ki  +0.8% +1.02Ki    Symbol Table
  +0.3%    +464  +0.3%    +464    __TEXT,__text
  +1.7%    +408  +1.7%    +408    __DATA,__objc_const
  +2.0%    +361  +2.0%    +361    __TEXT,__objc_methname
  +1.8%    +256  +1.8%    +256    __TEXT,__objc_stubs
  +0.5%     +72  +0.5%     +72    __TEXT,__gcc_except_tab
  +1.7%     +64  +1.7%     +64    __DATA,__objc_selrefs
  +0.5%     +39  +0.5%     +39    __TEXT,__cstring
  +0.6%     +32  +0.6%     +32    __DATA_CONST,__const
  +0.4%     +24  +0.4%     +24    __TEXT,__unwind_info
  +1.1%     +16  +1.1%     +16    Function Start Addresses
  +3.0%     +16  +3.0%     +16    __DATA,__objc_ivar
  +1.2%     +11  +1.2%     +11    [2 Others]
  +0.7%      +8  +0.7%      +8    Rebase Info
  -0.2%      -8  -0.2%      -8    Binding Info
  -0.4%     -12  -0.4%     -12    __TEXT,__const
  -2.7%     -32  -2.7%     -32    [__DATA_CONST]
 -73.8%    -496 -93.9%    -496    [__DATA]
  -2.8% -1.18Ki  -2.8% -1.18Ki    [__TEXT]
  [ = ]       0 -24.8% -2.09Ki    [__LINKEDIT]
  +0.4% +2.09Ki  [ = ]       0    TOTAL

Generated by 🚫 Danger

@robert-smartbear robert-smartbear force-pushed the robert/plat-14166_view_controller_dealloc_delay_fix branch 4 times, most recently from 9d86707 to b893180 Compare May 6, 2025 12:38
@robert-smartbear robert-smartbear force-pushed the robert/plat-14166_view_controller_dealloc_delay_fix branch from b893180 to a263c5d Compare May 6, 2025 12:43
@robert-smartbear robert-smartbear merged commit d0bd6a4 into next May 6, 2025
26 checks passed
@robert-smartbear robert-smartbear deleted the robert/plat-14166_view_controller_dealloc_delay_fix branch May 6, 2025 13:16
@robert-smartbear robert-smartbear mentioned this pull request May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载