+
Skip to content

[PLAT-13430] Speculatively collect rendering metrics before Bugsnag is started #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 31, 2025
Merged

[PLAT-13430] Speculatively collect rendering metrics before Bugsnag is started #405

merged 5 commits into from
Mar 31, 2025

Conversation

kstenerud
Copy link
Contributor

@kstenerud kstenerud commented Feb 27, 2025 •
edited
Loading

Goal

Start gathering metrics before Bugsnag starts, so that early spans can also get metrics data.

Design

Metrics gathering will now start immediately under the assumption that all metrics are enabled. Once Bugsnag.start() is called, we'll disable metrics if configured to do so.

Testing

Added e2e tests

@kstenerud kstenerud force-pushed the PLAT-13430-early-rendering-metrics branch from b3805d5 to c1c20e6 Compare February 27, 2025 13:05
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 27, 2025 •
edited
Loading

BugsnagPerformance.framework binary size increased by 1,136 bytes from 567,416 to 568,552

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.5%    +576  +0.5%    +576    Symbol Table
  +0.4%    +552  +0.4%    +552    String Table
  +0.4%    +536  +0.4%    +536    __TEXT,__text
  +1.4%    +192  +1.4%    +192    __TEXT,__objc_stubs
  +0.8%    +176  +0.8%    +176    __DATA,__objc_const
  +0.9%    +157  +0.9%    +157    __TEXT,__objc_methname
  +0.5%     +60  +0.5%     +60    __TEXT,__gcc_except_tab
  +1.3%     +48  +1.3%     +48    __DATA,__objc_selrefs
  +0.6%     +32  +0.6%     +32    __TEXT,__unwind_info
  +0.5%     +17  +0.5%     +17    __TEXT,__objc_methtype
  +0.6%      +8  +0.6%      +8    Function Start Addresses
  +0.8%      +4  +0.8%      +4    __DATA,__objc_ivar
 -17.6%    -228 -19.8%    -228    [__DATA]
  -2.4%    -994  -2.4%    -994    [__TEXT]
  [ = ]       0 -18.8% -1.11Ki    [__LINKEDIT]
  +0.2% +1.11Ki  [ = ]       0    TOTAL

Generated by 🚫 Danger

@kstenerud kstenerud force-pushed the PLAT-13430-early-rendering-metrics branch from c1c20e6 to 0be4ca6 Compare February 27, 2025 13:37
@kstenerud kstenerud marked this pull request as ready for review March 20, 2025 09:23
@kstenerud kstenerud merged commit 048101c into next Mar 31, 2025
25 checks passed
@kstenerud kstenerud deleted the PLAT-13430-early-rendering-metrics branch March 31, 2025 11:20
@robert-smartbear robert-smartbear mentioned this pull request Apr 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robert-smartbear robert-smartbear robert-smartbear approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kstenerud @robert-smartbear
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载