Don't send CPU data if cpu_mean_total is not available #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Generated by 🚫 Danger |
robert-smartbear
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
We shouldn’t send CPU metrics if there is no cpu_mean_total due to it being unavailable on the device.
Changeset
If
processSampleCountis zero that means thatcpu_mean_totalcannot be calculated.So we check for it early and don't calculate any other cpu related attribute.
Testing
Added new unit tests with
cpu_mean_totalbeing unavailable.Adjusted existing tests that checked main thread only and overhead only.