+
Skip to content

Harmonize code to get the class name, using Swift's built-in demangler #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 27, 2024
Merged

Harmonize code to get the class name, using Swift's built-in demangler #344

merged 2 commits into from
Nov 27, 2024

Conversation

kstenerud
Copy link
Contributor

Goal

The codebase had multiple different ways to get the name of a class for reporting. Unfortunately, most of them don't work with Swift name mangling.

Design

Harmonize all code paths to use a single class name getting function, and make sure it plays nice with Swift name mangling.

Testing

Added new e2e test.

@github-actions GitHub Actions
Copy link

BugsnagPerformance.framework binary size increased by 1,424 bytes from 518,448 to 519,872

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.7%    +872  +0.7%    +872    String Table
  +0.5%    +528  +0.5%    +528    Symbol Table
  +1.1%    +200  +1.1%    +200    __DATA,__objc_const
  +0.1%    +164  +0.1%    +164    __TEXT,__text
  +4.8%     +80  +4.8%     +80    __DATA,__objc_data
  +0.5%     +74  +0.5%     +74    __TEXT,__objc_methname
  +0.5%     +64  +0.5%     +64    __TEXT,__objc_stubs
  +0.6%     +46  +0.6%     +46    __TEXT,__cstring
  +0.4%     +32  +0.4%     +32    __DATA_CONST,__cfstring
  +0.6%     +32  +0.6%     +32    __DATA_CONST,__const
  [ = ]       0   +23%     +24    __DATA,__bss
  +3.1%     +18  +3.1%     +18    __TEXT,__objc_classname
  +1.6%     +16  +1.6%     +16    Rebase Info
  +0.5%     +16  +0.5%     +16    __DATA,__objc_selrefs
  +0.2%      +8  +0.2%      +8    Binding Info
  +1.7%      +8  +1.7%      +8    __DATA,__objc_classrefs
  -0.0%      -8  -0.0%      -8    [3 Others]
  -3.1%     -72  -3.1%     -72    [__DATA_CONST]
  -4.2%    -304  -4.6%    -328    [__DATA]
  -0.7%    -350  -0.7%    -350    [__TEXT]
  [ = ]       0 -24.4% -1.39Ki    [__LINKEDIT]
  +0.3% +1.39Ki  [ = ]       0    TOTAL

Generated by 🚫 Danger

@kstenerud kstenerud force-pushed the PLAT-13066-demangling branch 3 times, most recently from c0e5d51 to 2bf4f71 Compare November 22, 2024 15:23
@kstenerud kstenerud force-pushed the PLAT-13066-demangling branch 3 times, most recently from d18b49c to 52fa1de Compare November 22, 2024 15:56
@robert-smartbear robert-smartbear merged commit 21ecece into next Nov 27, 2024
25 checks passed
@robert-smartbear robert-smartbear deleted the PLAT-13066-demangling branch November 27, 2024 11:45
@robert-smartbear robert-smartbear mentioned this pull request Jan 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomlongridge tomlongridge tomlongridge approved these changes

@robert-smartbear robert-smartbear robert-smartbear approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kstenerud @tomlongridge @robert-smartbear
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载