Return the list of documents referenced in a Luna query. #995
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logic to
SycamoreQueryResult
to return the list of Document paths referenced by the query.The idea here is to provide a "reasonably selective" set of documents that a query is using in generating its final response. To this end we walk the query tree from the result node up and return the set of docs from the first node (or set of nodes) that return docs, rather than those that return non-doc values (like text chunks or singleton values).
This PR also adds the resulting set to the response returned in
query-server
.I ended up changing how this worked a bit from @baitsguy's previous implementation (in a private repo).