+
Skip to content

Conversation

mdwelsh
Copy link
Contributor

@mdwelsh mdwelsh commented Nov 1, 2024

This PR adds logic to SycamoreQueryResult to return the list of Document paths referenced by the query.

The idea here is to provide a "reasonably selective" set of documents that a query is using in generating its final response. To this end we walk the query tree from the result node up and return the set of docs from the first node (or set of nodes) that return docs, rather than those that return non-doc values (like text chunks or singleton values).

This PR also adds the resulting set to the response returned in query-server.

I ended up changing how this worked a bit from @baitsguy's previous implementation (in a private repo).

@mdwelsh mdwelsh requested review from baitsguy and dtecuci November 1, 2024 02:03
@dtecuci
Copy link
Contributor

dtecuci commented Nov 1, 2024

Looks good to me

@mdwelsh mdwelsh merged commit 358c30f into main Nov 1, 2024
12 of 13 checks passed
@HenryL27 HenryL27 deleted the matt/report-query-docs branch August 30, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载