+
Skip to content

Conversation

dhruvkaliraman7
Copy link
Contributor

@dhruvkaliraman7 dhruvkaliraman7 commented Oct 31, 2024

  1. Add a "column_headers" field to the table element, to store the column headers.
  2. While Splitting elements for tables, split at a new line character, and attach column headers and other metadata to table chunk.

Copy link
Collaborator

@HenryL27 HenryL27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now we've ended up with a bunch of duplicated code...

Copy link
Collaborator

@HenryL27 HenryL27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one nit

@dhruvkaliraman7 dhruvkaliraman7 merged commit b6346bf into main Oct 31, 2024
13 checks passed
@dhruvkaliraman7 dhruvkaliraman7 deleted the Add-Table_Chunking branch October 31, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载