+
Skip to content

Add query planning strategy objects #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 25, 2024
Merged

Add query planning strategy objects #982

merged 4 commits into from
Oct 25, 2024

Conversation

baitsguy
Copy link
Contributor

@baitsguy baitsguy commented Oct 25, 2024 •
edited
Loading

Allows the planner to work with a custom set of operators and rewrite rules. Added a default strategy (current behavior) and a vector search only strategy.

We might consider refactoring the plan processors eventually but this is functional for the current use cases.

You can enable this in evaluation by modifying

sycamore/apps/query-eval/queryeval/driver.py

Line 116 in c18c2eb

self.client = SycamoreQueryClient(
as

self.client = SycamoreQueryClient(
            llm_cache_dir=self.config.config.llm_cache_path,
            cache_dir=self.config.config.query_cache_path,
            llm=self.config.config.llm,
            query_plan_strategy=VectorSearchOnlyStrategy()
        )

@baitsguy baitsguy requested a review from mdwelsh October 25, 2024 19:09
@baitsguy baitsguy marked this pull request as ready for review October 25, 2024 19:11
mdwelsh
mdwelsh approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@mdwelsh mdwelsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YOU ARE A MACHINE

lib/sycamore/sycamore/query/strategy.py Outdated
self.llm = llm

def __call__(self, plan: LogicalPlan) -> LogicalPlan:
logging.info("Executing DefaultLogicalPlanProcessor")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logging statement not quite right

@baitsguy baitsguy enabled auto-merge (squash) October 25, 2024 23:36
@baitsguy baitsguy merged commit d130b54 into main Oct 25, 2024
10 of 13 checks passed
@baitsguy baitsguy deleted the low-data-query-mode branch October 25, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mdwelsh mdwelsh mdwelsh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@baitsguy @mdwelsh
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载