+
Skip to content

Fix mark_bbox_preset's MarkDropHeaderFooter parameter #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 23, 2024
Merged

Fix mark_bbox_preset's MarkDropHeaderFooter parameter #975

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cec8241
Fix `mark_bbox_preset`'s `MarkDropHeaderFooter` parameter
MarkLindblad Oct 23, 2024
247d17c
Move `hi`, `lo` logic to `mark_drop_header_and_footer` from `__init__`
MarkLindblad Oct 23, 2024
7a5d4f4
Fix transposing of arguments
MarkLindblad Oct 23, 2024
39d29f7
Revert first fix
MarkLindblad Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions lib/sycamore/sycamore/transforms/bbox_merge.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,15 +152,17 @@ class MarkDropHeaderFooter(SingleThreadUser, NonGPUUser, Map):
"""

def __init__(self, child: Node, top: float = 0.05, bottom: Optional[float] = None, **resource_args):
super().__init__(child, f=MarkDropHeaderFooter.mark_drop_header_and_footer, args=[top, bottom], **resource_args)

@staticmethod
@timetrace("markHeadFoot")
def mark_drop_header_and_footer(parent: Document, top: float = 0.05, bottom: Optional[float] = None) -> Document:
if bottom is None:
bottom = top

lo = top
hi = 1.0 - bottom
super().__init__(child, f=MarkDropHeaderFooter.mark_drop_header_and_footer, args=[lo, hi], **resource_args)

@staticmethod
@timetrace("markHeadFoot")
def mark_drop_header_and_footer(parent: Document, lo: float, hi: float) -> Document:
for elem in parent.elements:
bbox = elem.data.get("bbox")
if (bbox is not None) and ((bbox[1] > hi) or (bbox[3] < lo)):
Expand Down
Loading
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载