Add Lots of Connector Unit Tests #957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenryL27
approved these changes
Oct 22, 2024
| text_representation="text", | ||
| bbox=(0.0, 0.0, 1.0, 1.0), | ||
| shingles=[1, 2, 3], | ||
| embedding=[0.1, 0.2, 0.3, 0.4], |
There was a problem hiding this comment.
this is a diff num dimensions than the target_params. Guess doesn't matter since mock but if we ever implement a runtime check won't this break stuff (prob good to have break anyway, so I'd leave it. just flagging)
There was a problem hiding this comment.
You're right, think it might be best to leave it in, if we do implement a check we should change this test.
lib/sycamore/sycamore/tests/unit/connectors/duckdb/test_duckdb_writer.py
Outdated
Show resolved
Hide resolved
lib/sycamore/sycamore/tests/unit/connectors/duckdb/test_duckdb_writer.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds unit tests for the Pinecone, Elasticsearch, and DuckDB readers and writers, fixes bugs, and refactors DuckDB to not hardcode the schema.