Fix mypy warnings. #947
Merged
Fix mypy warnings. #947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsowell
reviewed
Oct 18, 2024
| assert 'Revealed type is "builtins.int"' in mypy_res[0] | ||
| def test_mypy_type() -> None: | ||
| res = require_fn() | ||
| assert_type(res, int) |
There was a problem hiding this comment.
assert_type is only present in Python 3.11, so I would expect your unit tests to fail on 3.9 and 3.10.
There was a problem hiding this comment.
Turns out this does work if we import from typing_extensions!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues in the code that were leading to a bunch of mypy warnings. We now get no output from mypy when running on this branch (which is good).
It also replaces the test that was using
reveal_typewith the equivalent (and simpler)assert_type.