+
Skip to content

Conversation

baitsguy
Copy link
Contributor

@baitsguy baitsguy commented Oct 16, 2024

kwargs were being populated by @context_params but unused in the function. They were being passed as is to the underlying ray dataset execution which would complain about unknown additional args. Removed kwargs since it isn't needed here. This was breaking on a vector search query plan but undetected because the integ tests are broken.

Fixed result node naming in sycamore query codegen. Undetected because integ tests broken

@baitsguy baitsguy marked this pull request as ready for review October 16, 2024 00:26
@baitsguy baitsguy requested a review from mdwelsh October 16, 2024 00:26
@baitsguy baitsguy enabled auto-merge (squash) October 16, 2024 00:26
@baitsguy baitsguy merged commit e676f3d into main Oct 16, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载