+
Skip to content

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Sep 27, 2022

Resolves #373

  • Enable ElementaNodal plotting for a simple bar of Hex8.
  • Enable ElementalNodal plotting for partial results.
  • Enable ElementalNodal plotting for download_hemisphere with a mix of solid linear and quadratic elements.
  • Enable ElementalNodal plotting for shell elements with multiple layers.

@PProfizi PProfizi added the enhancement New feature or request label Sep 27, 2022
@PProfizi
Copy link
Contributor Author

For quadratic elements, PyVista's shrinked grid expects a certain number of data values while there is less available in the DPF Field's data array.
size(Field.data) < size(grid.active_scalar)

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Attention: Patch coverage is 86.86869% with 13 lines in your changes missing coverage. Please review.

Project coverage is 84.24%. Comparing base (f0b3727) to head (0c5aa13).
Report is 6 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #511      +/-   ##
==========================================
+ Coverage   84.16%   84.24%   +0.08%     
==========================================
  Files          91       91              
  Lines       10597    10672      +75     
==========================================
+ Hits         8919     8991      +72     
- Misses       1678     1681       +3     

@aukselis-c1connections
Copy link

Any updates on this one? Looks like a useful feature.

@PProfizi PProfizi force-pushed the feat/plot_ElementalNodal branch from 387623b to 477a2c1 Compare July 4, 2025 07:55
Copy link
Contributor

github-actions bot commented Jul 7, 2025

Pull request documentation preview limit (10) reached: skipping documentation deployment for this pull request.

@PProfizi PProfizi marked this pull request as ready for review July 7, 2025 13:42
@PProfizi PProfizi requested a review from rafacanton July 8, 2025 15:59
@PProfizi
Copy link
Contributor Author

PProfizi commented Jul 8, 2025

Hey @rafacanton it looks like something was fixed for 25R2 that allows this new feature to work.
Not sure if I should try to find a workaround for older DPF versions, or if I should mark the option as only available starting with 25R2.
I am downloading 25R1 to debug.
It may also be specific to this file. I think I remember something linked to the number of entities reported in result fields for shells vs the number of elements reported in the mesh.

Edit: after debugging I can confirm I am falling right into an old bug. This has nothing to do with plotting, it is the Field._get_data which fails.

@PProfizi PProfizi merged commit 7c5a4c4 into master Jul 9, 2025
45 of 46 checks passed
@PProfizi PProfizi deleted the feat/plot_ElementalNodal branch July 9, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement plotting of ElementNodal

4 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载