+
Skip to content

Conversation

SMoraisAnsys
Copy link
Contributor

@SMoraisAnsys SMoraisAnsys commented Jun 11, 2024

Removes zip & upload even when one doesn't ask for it... (add missing if statement in the doc build workflow)

@SMoraisAnsys SMoraisAnsys requested a review from a team as a code owner June 11, 2024 08:04
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Defects or glitches reported by users or developers label Jun 11, 2024
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha - LGTM! Thanks for the quick fix

@RobPasMue RobPasMue changed the title FIX: Only zip and upload if asked fix: Only zip and upload if asked Jun 11, 2024
@SMoraisAnsys SMoraisAnsys changed the title fix: Only zip and upload if asked fix: only zip and upload if asked Jun 11, 2024
Copy link
Contributor

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix.

@SMoraisAnsys
Copy link
Contributor Author

Merging since it worked when using PR branch.

@SMoraisAnsys SMoraisAnsys merged commit 0459ad0 into main Jun 11, 2024
@SMoraisAnsys SMoraisAnsys deleted the fix/upload-assets branch June 11, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Defects or glitches reported by users or developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载