-
-
Notifications
You must be signed in to change notification settings - Fork 279
fix(vite-plugin-angular): include analog page files in additional compilation includes #1264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vite-plugin-angular): include analog page files in additional compilation includes #1264
Conversation
✅ Deploy Preview for analog-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-blog ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for analog-ng-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
It has been registered but shows that it missing export default, can you provide more info what can be wrong? @brandonroberts |
So I've made proposed changes but there is still same error @brandonroberts |
@illunix needs a fix here const globs = [
...pluginOptions.include.map((glob) => `${workspaceRoot}${glob}`),
...pluginOptions.include.map((glob) => `${workspaceRoot}${glob}`.replace(/\.ts$/, '.analog'),
]; |
You mean to add this second line in array or what? Because in the og code this line does not exist |
Yes, add the second line to the array |
So I've already tried and it gives same error, about missing default export |
@illunix you may to restart the dev server locally and hard refresh |
Okey, I'll try again in a couple of minutes |
I've tried, and as I said, still there is this error @brandonroberts, is it working for u? |
Yes, it works locally for me with all the changes |
@brandonroberts Then look at the https://github.com/analogjs/analog/pull/1264/files changed files and tell me if I missed something or everything is right, because I think I've done all required changes |
@brandonroberts I've tested right now after your changes and still this error occurs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
.analog and .agx files are not includes when they are in additional dir paths
Closes #
[optional] What gif best describes this PR or how it makes you feel?