+
Skip to content

refactor(router): remove unnecessary type casting #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

markostanimirovic
Copy link
Member

PR Checklist

What is the new behavior?

Type casting for provideRouter result is not needed since Angular v16

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

🧹

Copy link

netlify bot commented Jul 27, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit eb3162d
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/66a505017d71450008c61f15
😎 Deploy Preview https://deploy-preview-1233--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 27, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit eb3162d
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/66a5050114950a0008ae0aca
😎 Deploy Preview https://deploy-preview-1233--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 27, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit eb3162d
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/66a50501bde4a50008207a57
😎 Deploy Preview https://deploy-preview-1233--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 27, 2024

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit eb3162d
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/66a50501fa53ee0008362806
😎 Deploy Preview https://deploy-preview-1233--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts merged commit dcbd2c6 into beta Jul 28, 2024
24 checks passed
@brandonroberts brandonroberts deleted the refactor/router/remove-type-casting branch July 28, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载