+
Skip to content

fix: disable esbuild if not configured to enable correct sourcemaps #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2024
Merged

fix: disable esbuild if not configured to enable correct sourcemaps #1177

merged 1 commit into from
Jun 22, 2024

Conversation

brandonroberts
Copy link
Member

@brandonroberts brandonroberts commented Jun 22, 2024 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • vitest-angular
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

Sourcemaps were not working correctly.

Closes #86
Closes #1147
Closes #822

What is the new behavior?

  • Sourcemaps are working correctly if esbuild is disabled. If the user provides a custom esbuild config, it is respected.
  • Sourcemaps are working for .analog files
  • Breakpoints are working correctly in the browser devtools

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

@netlify Netlify
Copy link

netlify bot commented Jun 22, 2024 •
edited
Loading

✅ Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 14addb4
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/667660b26fa1e0000812b948
😎 Deploy Preview https://deploy-preview-1177--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jun 22, 2024 •
edited
Loading

✅ Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 14addb4
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/667660b20174860008589e7d
😎 Deploy Preview https://deploy-preview-1177--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jun 22, 2024 •
edited
Loading

✅ Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 14addb4
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/667660b29ac5900008be7d0c
😎 Deploy Preview https://deploy-preview-1177--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jun 22, 2024 •
edited
Loading

✅ Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit 14addb4
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/667660b20a841a000859f750
😎 Deploy Preview https://deploy-preview-1177--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts changed the title fix: disable esbuild if not configured to enable support for sourcemaps fix: disable esbuild if not configured to enable correct sourcemaps Jun 22, 2024
@brandonroberts brandonroberts merged commit c51e472 into beta Jun 22, 2024
24 checks passed
@brandonroberts brandonroberts deleted the fix-vite-plugin-sourcemaps branch June 22, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@brandonroberts
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载