+
Skip to content

WIP: docs: create docs on integrating with storybook #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

WIP: docs: create docs on integrating with storybook #1170

wants to merge 1 commit into from

Conversation

RyanClementsHax
Copy link
Contributor

@RyanClementsHax RyanClementsHax commented Jun 18, 2024 •
edited
Loading

PR Checklist

Part of brandonroberts/angular-vite-storybook#7

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Which package are you modifying?

  • vite-plugin-angular
  • vite-plugin-nitro
  • vitest-angular
  • astro-angular
  • create-analog
  • router
  • platform
  • content
  • nx-plugin
  • trpc

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Awesome

@netlify Netlify
Copy link

netlify bot commented Jun 18, 2024 •
edited
Loading

✅ Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit e0df799
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/6670d778641d8e000838b2b6
😎 Deploy Preview https://deploy-preview-1170--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jun 18, 2024 •
edited
Loading

✅ Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit e0df799
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/6670d7783ebfaf0008299feb
😎 Deploy Preview https://deploy-preview-1170--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jun 18, 2024 •
edited
Loading

✅ Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit e0df799
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/6670d778bfd0b40008b4be30
😎 Deploy Preview https://deploy-preview-1170--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jun 18, 2024 •
edited
Loading

✅ Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit e0df799
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/6670d77874466900081cf437
😎 Deploy Preview https://deploy-preview-1170--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@RyanClementsHax RyanClementsHax changed the title docs: create docs on integrating with storybook WIP: docs: create docs on integrating with storybook Jun 18, 2024
@RyanClementsHax
Copy link
Contributor Author

@brandonroberts consider this to be WIP. I'm testing this on a mantis project to see if it will hold in a different type of project. So far I'm getting Cannot destructure property 'id' of 'defaultExport' as it is undefined. errors.

My work is on this branch if you want to follow https://github.com/RyanClementsHax/nx-storybook-repro/tree/storybook-analog

npm i
npx nx storybook web-client

@RyanClementsHax
Copy link
Contributor Author

FYI work has been crazy and getting free time has been difficult. I'll try to work on this when I can but won't be offended if someone has to take this over.

cc @brandonroberts

@brandonroberts
Copy link
Member

@RyanClementsHax no problem. Will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RyanClementsHax @brandonroberts
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载