You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defaults are added back. Note that I didn't add tests, because I have no idea how that could be tested or whether it even should be. Also I didn't investigate whether adding 'style' is even necessary and just assumed it to be correct. If it isn't, the entire block could be removed instead, as there is a fallback to the defaults in that case.
Does this PR introduce a breaking change?
Yes, in theory
No, in practice
The fact that this was not done when upgrading to Vite 6 was a breaking change. So if at all this could only be a breaking change for people who somehow started relying on the broken behavior since then. Because people might have used now obsolete workarounds, it's definitely worth adding a note though.
Oh yea, I could have added that to the description, because that turned out to be the same problem for me. The tslib exceptions mentioned in the issue, were caused because default: "./tslib.js" was imported rather than module.default: "./tslib.es6.mjs". Well I guess now you can remove an obsolete workaround just like I mentioned above 😁.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Closes #1847
What is the new behavior?
Defaults are added back. Note that I didn't add tests, because I have no idea how that could be tested or whether it even should be. Also I didn't investigate whether adding
'style'is even necessary and just assumed it to be correct. If it isn't, the entire block could be removed instead, as there is a fallback to the defaults in that case.Does this PR introduce a breaking change?
The fact that this was not done when upgrading to Vite 6 was a breaking change. So if at all this could only be a breaking change for people who somehow started relying on the broken behavior since then. Because people might have used now obsolete workarounds, it's definitely worth adding a note though.