test(vite-plugin-angular): fix path resolution for Windows #1861
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
On Windows generated paths are
./app.component.css|C:/path/to/src/app.component.css
rather than./app.component.css|/path/to/src/app.component.css
, causing tests to fail. Trying to understand where this issue is coming from, I found some older PRs (#275 and #799), that tried to utilize vite'snormalizePath()
, which used to also take care of Windows' drive letters, though that was ages ago.Closes #1860
What is the new behavior?
./app.component.css|/path/to/src/app.component.css
now properly maps to./app.component.css|/path/to/src/app.component.css
..replace(/\\/g, '/')
which is already taken care of bynormalizePath()
.actualPaths -> expectedPaths
because actual actual paths 😏 are generated by the resolver.Does this PR introduce a breaking change?