+
Skip to content

chore: release 1.13.1 #1616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Feb 17, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
b378f0d
Merge branch 'main' into beta
brandonroberts Jan 27, 2025
223f019
docs(astro-angular): add docs on filtering file transforms with Astro…
brandonroberts Jan 28, 2025
02ea46d
build: only build packages during release job (#1583)
brandonroberts Jan 29, 2025
9b8c90d
fix(vite-plugin-angular): cache MarkedSetupService creation (#1584)
joshuamorony Jan 30, 2025
3c96506
chore: release 1.13.1-beta.1 [skip ci]
semantic-release-bot Jan 30, 2025
03820e9
ci: bump artifact actions to v4 (#1588)
brandonroberts Feb 3, 2025
bdc0fb9
docs: add Bun support for creating, serving, and building Analog apps…
JeevanMahesha Feb 3, 2025
0b4e245
fix(vite-plugin-angular): support double quotes in analog import attr…
BaptisteMahe Feb 3, 2025
68f4122
docs: add BaptisteMahe as a contributor for code (#1591)
allcontributors[bot] Feb 3, 2025
3eb5fa9
fix(vite-plugin-angular): cache resource reads for agx files (#1587)
joshuamorony Feb 3, 2025
366a462
ci: install corepack 0.31.0 to fix installation issues
brandonroberts Feb 3, 2025
17bf51f
chore: release 1.13.1-beta.2 [skip ci]
semantic-release-bot Feb 3, 2025
718a0dc
fix(vite-plugin-angular): add exception for agx to resourceNameToFile…
joshuamorony Feb 5, 2025
9924300
chore: release 1.13.1-beta.3 [skip ci]
semantic-release-bot Feb 5, 2025
4ff66a4
fix(vite-plugin-angular): check for style extension in resourceNameTo…
joshuamorony Feb 5, 2025
8757ffd
chore: release 1.13.1-beta.4 [skip ci]
semantic-release-bot Feb 5, 2025
faeaaf9
build: bump Vitest to 3.0.5 (#1594)
brandonroberts Feb 5, 2025
9cae439
fix(vite-plugin-angular): add detection for Vitest CLI in watch mode …
brandonroberts Feb 7, 2025
dadcfb0
chore: release 1.13.1-beta.5 [skip ci]
semantic-release-bot Feb 7, 2025
44b29cf
refactor: update to new Angular v19 features (#1603)
JeevanMahesha Feb 7, 2025
16e6ba9
refactor: upgrade prettier to support new Angular syntax (#1604)
ajitzero Feb 8, 2025
744ed1f
fix(vite-plugin-angular): remove check for Vitest command in watch mo…
brandonroberts Feb 10, 2025
b104183
chore: release 1.13.1-beta.6 [skip ci]
semantic-release-bot Feb 10, 2025
6a8fc20
fix(router): properly parse json response in the FormAction (#1605)
milosdanilov Feb 12, 2025
c495e5f
chore: release 1.13.1-beta.7 [skip ci]
semantic-release-bot Feb 12, 2025
636331d
docs: add milosdanilov as a contributor for code (#1608)
allcontributors[bot] Feb 12, 2025
272eabc
fix(vitest-angular): expand semver range of @angular-devkit/architect…
r-yanyo Feb 13, 2025
968e9b7
chore: release 1.13.1-beta.8 [skip ci]
semantic-release-bot Feb 13, 2025
8c9c8bc
docs: add r-yanyo as a contributor for infra (#1612)
allcontributors[bot] Feb 13, 2025
bf553b0
chore: update prettier and run formatting
brandonroberts Feb 13, 2025
06b349c
build: update .node-version to 22.14.0 for corepack fix
brandonroberts Feb 13, 2025
0bd7cf8
ci: bump workflow actions
brandonroberts Feb 14, 2025
766f154
docs: add extra instructions to use vitest in zoneless apps (#1614)
osnoser1 Feb 17, 2025
9340ce8
docs: add osnoser1 as a contributor for doc (#1615)
allcontributors[bot] Feb 17, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 30 additions & 2 deletions .all-contributorsrc
Original file line number Diff line number Diff line change
Expand Up @@ -701,7 +701,7 @@
"login": "ajitzero",
"name": "Ajit Panigrahi",
"avatar_url": "https://avatars.githubusercontent.com/u/19947758?v=4",
"profile": "https://beta.ajitpanigrahi.com",
"profile": "https://ajitpanigrahi.com",
"contributions": [
"code"
]
Expand Down Expand Up @@ -1103,7 +1103,8 @@
"avatar_url": "https://avatars.githubusercontent.com/u/1179744?v=4",
"profile": "https://github.com/osnoser1",
"contributions": [
"code"
"code",
"doc"
]
},
{
Expand Down Expand Up @@ -1214,6 +1215,33 @@
"contributions": [
"code"
]
},
{
"login": "BaptisteMahe",
"name": "Baptiste Mahé",
"avatar_url": "https://avatars.githubusercontent.com/u/41227846?v=4",
"profile": "https://www.linkedin.com/in/baptiste-mah%C3%A9-95b425180/",
"contributions": [
"code"
]
},
{
"login": "milosdanilov",
"name": "Miloš Danilov",
"avatar_url": "https://avatars.githubusercontent.com/u/12774464?v=4",
"profile": "https://github.com/milosdanilov",
"contributions": [
"code"
]
},
{
"login": "r-yanyo",
"name": "r-yanyo",
"avatar_url": "https://avatars.githubusercontent.com/u/6813556?v=4",
"profile": "https://www.r-yanyo.com/profile",
"contributions": [
"infra"
]
}
],
"contributorsPerLine": 7,
Expand Down
20 changes: 10 additions & 10 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ jobs:
- uses: actions/setup-node@v3
with:
node-version-file: .node-version
- run: npm install --global corepack@0.31.0
- run: corepack enable
- run: pnpm --version
- uses: actions/setup-node@v3
Expand All @@ -39,7 +40,7 @@ jobs:
run: pnpm install --frozen-lockfile --prefer-offline

- name: Validate
run: pnpm exec prettier --check .
run: pnpm run prettier:check

build:
runs-on: ubuntu-latest
Expand All @@ -48,6 +49,7 @@ jobs:
- uses: actions/setup-node@v3
with:
node-version-file: .node-version
- run: npm install --global corepack@0.31.0
- run: corepack enable
- run: pnpm --version
- uses: actions/setup-node@v3
Expand All @@ -67,11 +69,6 @@ jobs:
with:
node-version-file: .node-version
- run: corepack enable
- run: pnpm --version
- uses: actions/setup-node@v3
with:
cache: 'pnpm'
cache-dependency-path: '**/pnpm-lock.yaml'
- name: Install
run: pnpm install --frozen-lockfile --prefer-offline
- name: Build
Expand All @@ -86,6 +83,7 @@ jobs:
- uses: actions/setup-node@v3
with:
node-version-file: .node-version
- run: npm install --global corepack@0.31.0
- run: corepack enable
- run: pnpm --version
- uses: actions/setup-node@v3
Expand All @@ -106,6 +104,7 @@ jobs:
- uses: actions/setup-node@v3
with:
node-version-file: .node-version
- run: npm install --global corepack@0.31.0
- run: corepack enable
- run: pnpm --version
- uses: actions/setup-node@v3
Expand All @@ -128,6 +127,7 @@ jobs:
- uses: actions/setup-node@v3
with:
node-version-file: .node-version
- run: npm install --global corepack@0.31.0
- run: corepack enable
- run: pnpm --version
- uses: actions/setup-node@v3
Expand All @@ -141,7 +141,7 @@ jobs:
- name: Upload docs website
# Runs on merge to the `beta` branch
if: github.event_name == 'push' && github.ref_name == 'beta'
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
if-no-files-found: error
name: ${{ env.DOCS_APP_ARTIFACT_NAME }}
Expand Down Expand Up @@ -182,16 +182,16 @@ jobs:
cancel-in-progress: ${{ github.event_name != 'push' }}
steps:
- name: Download docs website
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: ${{ env.DOCS_APP_ARTIFACT_NAME }}
path: ${{ env.DOCS_APP_PATH }}
- name: Set up GitHub Pages
uses: actions/configure-pages@v1
- name: Upload GitHub Pages-compatible tarball
uses: actions/upload-pages-artifact@v1
uses: actions/upload-pages-artifact@v3
with:
path: ${{ env.DOCS_APP_PATH }}
- name: Deploy docs website tarball
id: deploy
uses: actions/deploy-pages@v1
uses: actions/deploy-pages@v4
1 change: 1 addition & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ jobs:
uses: actions/setup-node@v3
with:
node-version-file: .node-version
- run: npm install --global corepack@0.31.0
- run: corepack enable
- run: pnpm --version
- name: Install dependencies
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/test-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/setup-node@v3
- run: npm install --global corepack@0.31.0
- run: corepack enable
- run: npm --version
- name: Create Analog Application
Expand All @@ -49,6 +50,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/setup-node@v3
- run: npm install --global corepack@0.31.0
- run: corepack enable
- run: npm --version
- name: Create Nx Workspace
Expand All @@ -66,6 +68,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/setup-node@v3
- run: npm install --global corepack@0.31.0
- run: corepack enable
- run: npm --version
- name: Create Angular App
Expand Down
2 changes: 1 addition & 1 deletion .node-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
22.8.0
22.14.0
1 change: 1 addition & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@ pnpm-lock.yaml
*.analog
/.nx/workspace-data
/packages/create-analog/template-*
.vite-inspect
7 changes: 7 additions & 0 deletions .prettierrc
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
{
"singleQuote": true,
"trailingComma": "all",
"overrides": [
{
"files": "*.md",
"options": {
"printWidth": 80
}
},
{
"files": "*.analog",
"options": {
Expand Down
49 changes: 49 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,52 @@
## [1.13.1-beta.8](https://github.com/analogjs/analog/compare/v1.13.1-beta.7...v1.13.1-beta.8) (2025-02-13)

### Bug Fixes

- **vitest-angular:** expand semver range of @angular-devkit/architect ([#1611](https://github.com/analogjs/analog/issues/1611)) ([272eabc](https://github.com/analogjs/analog/commit/272eabc529e6f1000dcad9c9185a36a150ca586e))

## [1.13.1-beta.7](https://github.com/analogjs/analog/compare/v1.13.1-beta.6...v1.13.1-beta.7) (2025-02-12)

### Bug Fixes

- **router:** properly parse json response in the FormAction ([#1605](https://github.com/analogjs/analog/issues/1605)) ([6a8fc20](https://github.com/analogjs/analog/commit/6a8fc20037d28720b9aa809ef1670f2f6b19ee6b))

## [1.13.1-beta.6](https://github.com/analogjs/analog/compare/v1.13.1-beta.5...v1.13.1-beta.6) (2025-02-10)

### Bug Fixes

- **vite-plugin-angular:** remove check for Vitest command in watch mode ([#1606](https://github.com/analogjs/analog/issues/1606)) ([744ed1f](https://github.com/analogjs/analog/commit/744ed1fcf8f2f3228177698fc81fc64d1648110e))

## [1.13.1-beta.5](https://github.com/analogjs/analog/compare/v1.13.1-beta.4...v1.13.1-beta.5) (2025-02-07)

### Bug Fixes

- **vite-plugin-angular:** add detection for Vitest CLI in watch mode ([#1602](https://github.com/analogjs/analog/issues/1602)) ([9cae439](https://github.com/analogjs/analog/commit/9cae43967c62dad40cba9500dc78071a5601b33b))

## [1.13.1-beta.4](https://github.com/analogjs/analog/compare/v1.13.1-beta.3...v1.13.1-beta.4) (2025-02-05)

### Bug Fixes

- **vite-plugin-angular:** check for style extension in resourceNameToFileName ([#1596](https://github.com/analogjs/analog/issues/1596)) ([4ff66a4](https://github.com/analogjs/analog/commit/4ff66a4ddcfe29534d1c680230f7ddfd6b5bb0f2))

## [1.13.1-beta.3](https://github.com/analogjs/analog/compare/v1.13.1-beta.2...v1.13.1-beta.3) (2025-02-05)

### Bug Fixes

- **vite-plugin-angular:** add exception for agx to resourceNameToFileName ([#1595](https://github.com/analogjs/analog/issues/1595)) ([718a0dc](https://github.com/analogjs/analog/commit/718a0dcd52ce50a51dec9458385a0fa070b8be07))

## [1.13.1-beta.2](https://github.com/analogjs/analog/compare/v1.13.1-beta.1...v1.13.1-beta.2) (2025-02-03)

### Bug Fixes

- **vite-plugin-angular:** cache resource reads for agx files ([#1587](https://github.com/analogjs/analog/issues/1587)) ([3eb5fa9](https://github.com/analogjs/analog/commit/3eb5fa95fb85a577dc7eca325b775599e413ee9e))
- **vite-plugin-angular:** support double quotes in analog import attributes ([#1590](https://github.com/analogjs/analog/issues/1590)) ([0b4e245](https://github.com/analogjs/analog/commit/0b4e245a37774c5bcc448029cfb3fd558636d96f))

## [1.13.1-beta.1](https://github.com/analogjs/analog/compare/v1.13.0...v1.13.1-beta.1) (2025-01-30)

### Bug Fixes

- **vite-plugin-angular:** cache MarkedSetupService creation ([#1584](https://github.com/analogjs/analog/issues/1584)) ([9b8c90d](https://github.com/analogjs/analog/commit/9b8c90d1451844867ba3b7d79b0aaa11b5428527))

# [1.13.0](https://github.com/analogjs/analog/compare/v1.12.2...v1.13.0) (2025-01-27)

### Bug Fixes
Expand Down
9 changes: 6 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<!-- prettier-ignore-start -->
<!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->
[![All Contributors](https://img.shields.io/badge/all_contributors-128-orange.svg?style=flat-square)](#contributors-)
[![All Contributors](https://img.shields.io/badge/all_contributors-131-orange.svg?style=flat-square)](#contributors-)
<!-- ALL-CONTRIBUTORS-BADGE:END -->
<!-- prettier-ignore-end -->

Expand Down Expand Up @@ -205,7 +205,7 @@ Thanks goes to these wonderful people for contributing to Analog ([emoji key](ht
<tr>
<td align="center" valign="top" width="14.28%"><a href="https://twitter.com/OCombe"><img src="https://avatars.githubusercontent.com/u/265378?v=4?s=100" width="100px;" alt="Olivier Combe"/><br /><sub><b>Olivier Combe</b></sub></a><br /><a href="https://github.com/analogjs/analog/commits?author=ocombe" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/sasidharansd"><img src="https://avatars.githubusercontent.com/u/47988127?v=4?s=100" width="100px;" alt="Sasidharan SD"/><br /><sub><b>Sasidharan SD</b></sub></a><br /><a href="https://github.com/analogjs/analog/commits?author=sasidharansd" title="Documentation">📖</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://beta.ajitpanigrahi.com"><img src="https://avatars.githubusercontent.com/u/19947758?v=4?s=100" width="100px;" alt="Ajit Panigrahi"/><br /><sub><b>Ajit Panigrahi</b></sub></a><br /><a href="https://github.com/analogjs/analog/commits?author=ajitzero" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://ajitpanigrahi.com"><img src="https://avatars.githubusercontent.com/u/19947758?v=4?s=100" width="100px;" alt="Ajit Panigrahi"/><br /><sub><b>Ajit Panigrahi</b></sub></a><br /><a href="https://github.com/analogjs/analog/commits?author=ajitzero" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/nemu69"><img src="https://avatars.githubusercontent.com/u/43633395?v=4?s=100" width="100px;" alt="nepage-l"/><br /><sub><b>nepage-l</b></sub></a><br /><a href="https://github.com/analogjs/analog/commits?author=nemu69" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://jeffreysmith.ninja"><img src="https://avatars.githubusercontent.com/u/5161547?v=4?s=100" width="100px;" alt="Jeff"/><br /><sub><b>Jeff</b></sub></a><br /><a href="https://github.com/analogjs/analog/commits?author=Jefftopia" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://sammymohamed.com"><img src="https://avatars.githubusercontent.com/u/22568206?v=4?s=100" width="100px;" alt="Sammy Mohamed"/><br /><sub><b>Sammy Mohamed</b></sub></a><br /><a href="https://github.com/analogjs/analog/commits?author=thatsamsonkid" title="Documentation">📖</a></td>
Expand Down Expand Up @@ -260,7 +260,7 @@ Thanks goes to these wonderful people for contributing to Analog ([emoji key](ht
<td align="center" valign="top" width="14.28%"><a href="https://github.com/DerHerrGammler"><img src="https://avatars.githubusercontent.com/u/30802629?v=4?s=100" width="100px;" alt="Felix Herold"/><br /><sub><b>Felix Herold</b></sub></a><br /><a href="https://github.com/analogjs/analog/commits?author=DerHerrGammler" title="Documentation">📖</a> <a href="#translation-DerHerrGammler" title="Translation">🌍</a></td>
<td align="center" valign="top" width="14.28%"><a href="http://soheilnazari.de"><img src="https://avatars.githubusercontent.com/u/113988347?v=4?s=100" width="100px;" alt="Soheil Nazari [CHECK24]"/><br /><sub><b>Soheil Nazari [CHECK24]</b></sub></a><br /><a href="https://github.com/analogjs/analog/commits?author=s0h311" title="Documentation">📖</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/illunix"><img src="https://avatars.githubusercontent.com/u/42069493?v=4?s=100" width="100px;" alt="Maksymilian Szokalski"/><br /><sub><b>Maksymilian Szokalski</b></sub></a><br /><a href="#infra-illunix" title="Infrastructure (Hosting, Build-Tools, etc)">🚇</a> <a href="https://github.com/analogjs/analog/commits?author=illunix" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/osnoser1"><img src="https://avatars.githubusercontent.com/u/1179744?v=4?s=100" width="100px;" alt="Alfonso Andrés López Molina"/><br /><sub><b>Alfonso Andrés López Molina</b></sub></a><br /><a href="https://github.com/analogjs/analog/commits?author=osnoser1" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/osnoser1"><img src="https://avatars.githubusercontent.com/u/1179744?v=4?s=100" width="100px;" alt="Alfonso Andrés López Molina"/><br /><sub><b>Alfonso Andrés López Molina</b></sub></a><br /><a href="https://github.com/analogjs/analog/commits?author=osnoser1" title="Code">💻</a> <a href="https://github.com/analogjs/analog/commits?author=osnoser1" title="Documentation">📖</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://arjunaditya.xyz"><img src="https://avatars.githubusercontent.com/u/73933669?v=4?s=100" width="100px;" alt="Nermal"/><br /><sub><b>Nermal</b></sub></a><br /><a href="https://github.com/analogjs/analog/commits?author=nermalcat69" title="Documentation">📖</a></td>
<td align="center" valign="top" width="14.28%"><a href="http://tobiasegli.ch"><img src="https://avatars.githubusercontent.com/u/20181671?v=4?s=100" width="100px;" alt="tobiasegli"/><br /><sub><b>tobiasegli</b></sub></a><br /><a href="https://github.com/analogjs/analog/commits?author=tobiasegli" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/lars0n"><img src="https://avatars.githubusercontent.com/u/15248125?v=4?s=100" width="100px;" alt="Larson"/><br /><sub><b>Larson</b></sub></a><br /><a href="https://github.com/analogjs/analog/commits?author=lars0n" title="Code">💻</a></td>
Expand All @@ -277,6 +277,9 @@ Thanks goes to these wonderful people for contributing to Analog ([emoji key](ht
<tr>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/alexrosepizant"><img src="https://avatars.githubusercontent.com/u/7753376?v=4?s=100" width="100px;" alt="Alex Rose-Pizant"/><br /><sub><b>Alex Rose-Pizant</b></sub></a><br /><a href="#infra-alexrosepizant" title="Infrastructure (Hosting, Build-Tools, etc)">🚇</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://mattlewis.me/"><img src="https://avatars.githubusercontent.com/u/6425649?v=4?s=100" width="100px;" alt="Matt Lewis"/><br /><sub><b>Matt Lewis</b></sub></a><br /><a href="https://github.com/analogjs/analog/commits?author=mattlewis92" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://www.linkedin.com/in/baptiste-mah%C3%A9-95b425180/"><img src="https://avatars.githubusercontent.com/u/41227846?v=4?s=100" width="100px;" alt="Baptiste Mahé"/><br /><sub><b>Baptiste Mahé</b></sub></a><br /><a href="https://github.com/analogjs/analog/commits?author=BaptisteMahe" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/milosdanilov"><img src="https://avatars.githubusercontent.com/u/12774464?v=4?s=100" width="100px;" alt="Miloš Danilov"/><br /><sub><b>Miloš Danilov</b></sub></a><br /><a href="https://github.com/analogjs/analog/commits?author=milosdanilov" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://www.r-yanyo.com/profile"><img src="https://avatars.githubusercontent.com/u/6813556?v=4?s=100" width="100px;" alt="r-yanyo"/><br /><sub><b>r-yanyo</b></sub></a><br /><a href="#infra-r-yanyo" title="Infrastructure (Hosting, Build-Tools, etc)">🚇</a></td>
</tr>
</tbody>
</table>
Expand Down
6 changes: 3 additions & 3 deletions apps/analog-app-e2e-cypress/src/e2e/cart.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ describe('Cart', () => {
onBeforeLoad: (win) => {
cy.stub(win.console, 'warn').as('consoleWarn');
},
})
}),
);

it(`Given the user has added a phone to the cart
Expand All @@ -33,7 +33,7 @@ describe('Cart', () => {
cart.navigateTo();

Object.values(phones).forEach((phone) =>
cart.getPriceByName(phone.name).contains(phone.price)
cart.getPriceByName(phone.name).contains(phone.price),
);
});

Expand All @@ -55,7 +55,7 @@ describe('Cart', () => {
cy.get('@consoleWarn').should(
'have.been.calledWithMatch',
/your order has been submitted/i,
{ name, address }
{ name, address },
);
cart.getItems().should('not.exist');
});
Expand Down
16 changes: 16 additions & 0 deletions apps/analog-app-e2e-cypress/src/e2e/newsletter.cy.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import * as newsletter from '../support/newsletter.po';

describe('Newsletter', () => {
it(`Given the user has filled in their email
When the "Submit" button is clicked
Then the user has sign up for the newsletter`, () => {
const email = 'someemail@email.com';
cy.visit('/newsletter');
newsletter.typeEmail(email);

newsletter.submit();
newsletter
.getSubmitMessage()
.should('contain.text', `Thanks for signing up, ${email}!`);
});
});
2 changes: 1 addition & 1 deletion apps/analog-app-e2e-cypress/src/e2e/products.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ describe('Products', () => {

cy.on('window:alert', (alert) => {
expect(alert).to.contain(
/you will be notified when the product goes on sale/i
/you will be notified when the product goes on sale/i,
);
});
});
Expand Down
6 changes: 6 additions & 0 deletions apps/analog-app-e2e-cypress/src/support/newsletter.po.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
export const typeEmail = (email: string) =>
cy.get('input[name="email"]').type(email);

export const submit = () => cy.contains('button', /submit/i).click();

export const getSubmitMessage = () => cy.get('#signup-message');
2 changes: 1 addition & 1 deletion apps/analog-app-e2e-playwright/tests/app.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ describe('My Store', () => {
test(`Given the user has navigated to the home page
Then the app title is visible`, async () => {
await expect(
page.locator('role=heading[level=1] >> text=My Store')
page.locator('role=heading[level=1] >> text=My Store'),
).toContain(/My Store/i);
});
});
8 changes: 4 additions & 4 deletions apps/analog-app-e2e-playwright/tests/cart.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ describe('Cart', () => {
});
await cartPage.navigateTo();
expect(
await cartPage.getPriceByName(phone.name, phone.price).elementHandle()
await cartPage.getPriceByName(phone.name, phone.price).elementHandle(),
).toBeTruthy();
});

Expand All @@ -92,12 +92,12 @@ describe('Cart', () => {

for (const phone of allPhones) {
expect(
await cartPage.getPriceByName(phone.name, phone.price).elementHandle()
await cartPage.getPriceByName(phone.name, phone.price).elementHandle(),
).toBeTruthy();
}

expect(await cartPage.cartItems().elementHandles()).toHaveLength(
allPhones.length
allPhones.length,
);
});

Expand Down Expand Up @@ -132,7 +132,7 @@ describe('Cart', () => {
await cartPage.purchaseOrder();

expect(await message[0].evaluate((p) => p)).toMatch(
/your order has been submitted/i
/your order has been submitted/i,
);
expect(await message[1].evaluate((p) => p)).toEqual({ name, address });
expect(await cartPage.cartItems().elementHandles()).toHaveLength(0);
Expand Down
Loading
Loading
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载