+
Skip to content

fix(vite-plugin-angular): remove check for Vitest command in watch mode #1606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 10, 2025

Conversation

brandonroberts
Copy link
Member

PR Checklist

Closes #

What is the new behavior?

Instead of checking for the vitest command when executed, check for the isTest which checks the proper environment variables already being set when running Vitest.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Feb 10, 2025

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 52c53d2
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/67aa38f9e4b66800087d2299
😎 Deploy Preview https://deploy-preview-1606--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 10, 2025

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 52c53d2
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/67aa38f91868b70008756c04
😎 Deploy Preview https://deploy-preview-1606--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts changed the title Fix vitest watch mode fix(vite-plugin-angular): remove check for Vitest command in watch mode Feb 10, 2025
Copy link

netlify bot commented Feb 10, 2025

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 52c53d2
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/67aa38f96504500009fd9729
😎 Deploy Preview https://deploy-preview-1606--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 10, 2025

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit 52c53d2
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/67aa38f94b2a0f0008df11b6
😎 Deploy Preview https://deploy-preview-1606--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts merged commit 744ed1f into beta Feb 10, 2025
22 of 24 checks passed
@brandonroberts brandonroberts deleted the fix-vitest-watch-mode branch February 10, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载