-
Notifications
You must be signed in to change notification settings - Fork 81
Add table
option for output-format
vulnerabilities in console
#135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add table
option for output-format
vulnerabilities in console
#135
Conversation
…running scan in blocking mode Signed-off-by: Ken Chou <ken.chou@finn.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be very useful! I'm currently struggling with this.
This would close #168 |
index.js
Outdated
|
||
if (failBuild === true) { | ||
if (showGrypeOutput) { | ||
core.info(cmdOutput); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe this is going to give a table-view output but only dumping the SARIF JSON, no?
This is a great idea -- however, I think we could probably do this without a config parameter to just always dump the table view to the console, WDYT? |
to be honest, that behavior would be a nice default to have. |
@kzantow is this a change that would need to go into grype itself or is it something that needs to happen in this action? |
@ken-chou-finn thank for your work on this PR. On @JAORMX's latest question: grype currently prints the table and then errors out, like in the example below:
We just need to make use of the table output, so no need to change grype, just this action. I am happy to help with this PR and get the feature delivered. |
@jonasagx that would be great! |
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Sorry this has taken a while to get back to -- I think we may want to combine this with #187 by allowing users to specify a One question: is there any situation a user wants to get both a table output printed and an output file of some sort? |
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
table
option for output-format
vulnerabilities in console
…running scan in blocking mode
Signed-off-by: Ken Chou ken.chou@finn.ai