+
Skip to content

Conversation

aliel
Copy link
Member

@aliel aliel commented Aug 29, 2025

  • Is my code clear enough and well documented
  • Are my files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • Database migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

@aliel aliel requested review from 1yam and olethanh and removed request for olethanh August 29, 2025 09:09
1yam
1yam previously approved these changes Aug 29, 2025
Copy link
Member

@1yam 1yam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@1yam
Copy link
Member

1yam commented Aug 29, 2025

I thought test was passing but 2 is failling :

@aliel aliel force-pushed the aliel-fix-balances-endpoint branch from 51e3265 to 6082dc9 Compare August 29, 2025 10:45
@aliel aliel requested a review from 1yam August 29, 2025 10:50
Copy link
Member

@1yam 1yam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aliel aliel merged commit 0cbe93b into main Aug 29, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载