Add support for tcp keepalive through socket2 #981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not fully implemented, probably should be using a custom structure for `TcpKeepalive` to avoid exposing `socket2` publicly. In that case, should we have the same feature flag as the `socket2` library? Or should we allow each setting and just warn when one is not available for the given platform ?
5109f94 to
d278529
Compare
|
Are there other things we might want to tweak using If this lands in std::net eventually, we can make the feature flags a no-op, but it'd be nice to not have many many flags in that case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not fully implemented, probably should be using a custom structure for
TcpKeepaliveto avoid exposingsocket2publicly.In that case, should we have the same feature flag as the
socket2library? Or should we allow each setting and just warn when one is not available for the given platform ?Fixes #547