Update metrics to include inner transactions. #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
==========================================
+ Coverage 67.66% 69.93% +2.27%
==========================================
Files 32 36 +4
Lines 1976 2428 +452
==========================================
+ Hits 1337 1698 +361
- Misses 570 641 +71
- Partials 69 89 +20
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shiqizng
reviewed
Jun 16, 2023
| innerTxn += numInnerTxn(txn.SignedTxnWithAD) | ||
| } | ||
| if innerTxn != 0 { | ||
| txnCountByType["inner"] = innerTxn |
There was a problem hiding this comment.
nit: it may be ok to record 0 inner txn count in this metric.
shiqizng
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update metrics to consider inner transactions.
Test Plan
New unit test.