logging(algod importer): better error messages for GetBlock. #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
=========================================
Coverage ? 67.10%
=========================================
Files ? 32
Lines ? 1809
Branches ? 0
=========================================
Hits ? 1214
Misses ? 530
Partials ? 65
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Eric-Warehime
approved these changes
Mar 10, 2023
shiqizng
approved these changes
Mar 13, 2023
| @@ -29,6 +34,11 @@ func init() { | |||
| ctx, cancel = context.WithCancel(context.Background()) | |||
| } | |||
|
|
|||
| // New initializes an algod importer | |||
| func New() *algodImporter { | |||
There was a problem hiding this comment.
nit: this probably doesn't need to be exported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Better error message for algod importer. The previous messages did not clearly indicate what the user needed to do.
Test Plan
New unit tests.