This repository was archived by the owner on Sep 17, 2024. It is now read-only.
fix: empty config folder was always created #579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! |
tarkah
added a commit
that referenced
this pull request
Mar 23, 2021
fixes regression introduced from #579. All files under the data directory implement the PersistentData trait which will make sure the data directory exists before saving under it. However logging doesn't follow this pattern and would try to create a file before we ensured data directory exists.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #576
We were initially always creating the config folder, even while
--dataarguments were passed. This is now fixed.Checklist
CHANGELOG.mdif knowledge of this change could be valuable to users