This repository was archived by the owner on Sep 17, 2024. It is now read-only.
weak auras fixes #470
Merged
weak auras fixes #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 4, 2021
|
@casperstorm so we don't actually need to account for "unkown" add-ons to fix the issue at #466. The percent encoding fix was all that was needed (the API wasn't returning inconsistent results, our URL was inconsistent with the badly encoded parameter sometimes being 1st, 2nd .. last in the list of slugs, changing the number of returned results). |
|
Users on both issues confirmed the fixes here resolved things for them! I'll go ahead and merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #465, #466
Proposed Changes
&symbol in it, causing error in built URLChecklist
CHANGELOG.mdif knowledge of this change could be valuable to users