+
Skip to content
This repository was archived by the owner on Sep 17, 2024. It is now read-only.

Feat/reimplement changelog #475

Merged
merged 3 commits into from
Jan 6, 2021
Merged

Conversation

tarkah
Copy link
Member

@tarkah tarkah commented Jan 6, 2021

Resolves #474

Proposed Changes

  • Add back inline changelog

Checklist

  • Tested on Windows
  • Tested on MacOS
  • Tested on Linux
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users

@tarkah tarkah requested a review from casperstorm January 6, 2021 20:48
Copy link
Member

@casperstorm casperstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, quick execution @tarkah.
I think its great, except that it seems like you have to "double click" to exit out of a expanded addon now because you loose the selection once you go into changelog. Thats the only thing i found.

I think @ZythDr will be happy with this PR :)

@tarkah
Copy link
Member Author

tarkah commented Jan 6, 2021

Good catch! I'll make sure the expanded row closes on first click, regardless of if the addon details are expanded or changelog is expanded.

@tarkah tarkah merged commit 67b63cd into development Jan 6, 2021
@tarkah tarkah deleted the feat/reimplement-changelog branch January 6, 2021 23:51
@tarkah tarkah linked an issue Jan 6, 2021 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Still on 0.5.3 because of this...
2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载