This repository was archived by the owner on Sep 17, 2024. It is now read-only.
fix catalog install flow #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Do not insert the catalog addon into our main addons vec until it has been successfully unpacked. - Make sure any existing addon that has the same addon folders as our newly installed addon is removed prior to inserting the new addon to prevent dupliates. - Make sure addon cache entries are removed when the addon is deleted or when the same addon is installed via catalog from the Curse source
|
You feel this is ready to be merged, @tarkah? |
|
Yup! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
been successfully unpacked.
newly installed addon is removed prior to inserting the new addon to
prevent dupliates.
or when the same addon is installed via catalog from the Curse source
Checklist
CHANGELOG.mdif knowledge of this change could be valuable to users